linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 1/4] ARM: tegra: Add AHB driver
Date: Thu, 26 Apr 2012 22:59:03 +0100	[thread overview]
Message-ID: <20120426215903.GH24211@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4F99A740.3080407@wwwdotorg.org>

On Thu, Apr 26, 2012 at 01:51:28PM -0600, Stephen Warren wrote:
> On 04/25/2012 05:07 AM, Hiroshi DOYU wrote:
> > The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced
> > High-performance Bus (AHB) architecture.
> > 
> > The AHB Arbiter controls AHB bus master arbitration. This effectively
> > forms a second level of arbitration for access to the memory
> > controller through the AHB Slave Memory device. The AHB pre-fetch
> > logic can be configured to enhance performance for devices doing
> > sequential access. Each AHB master is assigned to either the high or
> > low priority bin. Both Tegra20/30 have this AHB bus.
> > 
> > Some of configuration param could be passed from DT too.
> 
> I think this code looks reasonable. I'd like to see an ack from Russell,
> Arnd, and Olof on the final location of the files though.

Well, the big question which needs answering is whether this AHB software
interface is something specific to Tegra or whether it really is something
generic.  There's been some hints in the previous thread that it's
specific to Tegra, so it may not after all make sense for it to be a
generic driver.

However, we _have_ decided "no more drivers under arch/arm".  So I really
don't want to see "struct xxx_driver" appearing in any code under that
subdirectory or one of its decendents.  I don't have much more to say
about location than that.

  reply	other threads:[~2012-04-26 21:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25 11:07 [PATCHv3 1/4] ARM: tegra: Add AHB driver Hiroshi DOYU
2012-04-25 11:07 ` [PATCHv3 2/4] ARM: tegra: Add SMMU enabler in AHB Hiroshi DOYU
2012-04-25 11:29   ` Felipe Balbi
2012-04-25 15:51     ` Stephen Warren
2012-04-26  5:37       ` Hiroshi Doyu
2012-04-26 19:55   ` Stephen Warren
2012-04-26 20:26     ` Felipe Balbi
2012-04-26 20:32       ` Stephen Warren
2012-04-26 20:38         ` Felipe Balbi
2012-04-27  6:48           ` Hiroshi Doyu
2012-04-27  6:55             ` Hiroshi Doyu
2012-04-27 15:49             ` Stephen Warren
2012-04-25 11:07 ` [PATCHv3 3/4] iommu/tegra: smmu: Refrain from accessing to AHB registers Hiroshi DOYU
2012-04-26 19:58   ` Stephen Warren
2012-04-25 11:07 ` [PATCHv3 4/4] ARM: dt: tegra: Add device tree support for AHB Hiroshi DOYU
2012-04-26 20:01   ` Stephen Warren
2012-04-25 11:25 ` [PATCHv3 1/4] ARM: tegra: Add AHB driver Felipe Balbi
2012-04-25 13:01   ` Hiroshi Doyu
2012-04-26 19:51 ` Stephen Warren
2012-04-26 21:59   ` Russell King - ARM Linux [this message]
2012-04-27  5:40     ` Hiroshi Doyu
2012-04-30 14:47       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120426215903.GH24211@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).