From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: possible MXS-i2c bug
Date: Fri, 27 Apr 2012 17:53:38 +0200 [thread overview]
Message-ID: <201204271753.39516.marex@denx.de> (raw)
In-Reply-To: <20120427154119.GF16504@pengutronix.de>
Dear Wolfram Sang,
> > You can get a large list of i2c messages. In the current implementation,
> > yes, they're iterated in mxs_i2c_xfer_msg. Correct.
> >
> > If you want to do DMA transfer do/from the i2c controller, you have to
> > take all these messages and create the chain of DMA transfers according
> > to these messages, correct?
>
> This is what I wonder. I'd think one could work on a per message basis.
But then you don't have the DMA chain linked. Which I wonder if the controller
has any problem with or not. I tried yesterday, got wrotes working perfectly,
but still had issues with reads, which is exactly what needs to be chained.
I'll poke further eventually.
> Regarding Figure 27-10, the first I2C write command could be sent
> seperately (probably even via PIOQUEUE).
I wonder if we want to combine pioqueue and DMA, that might create quite some
franken-driver.
> The only thing to be chained is
> the I2C read command and the actual reading of the data.
>
> Just checked, the FSL driver does it basically this way, too.
Which doesn't mean FSL driver does it correctly, but it probably worked for them
and there was some bug in my DMA tinkering.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-27 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 11:26 possible MXS-i2c bug Marek Vasut
2012-04-26 11:41 ` Fabio Estevam
2012-04-26 11:42 ` Wolfram Sang
2012-04-26 23:10 ` Marek Vasut
2012-04-27 14:59 ` Wolfram Sang
2012-04-27 15:08 ` Marek Vasut
2012-04-27 15:41 ` Wolfram Sang
2012-04-27 15:53 ` Marek Vasut [this message]
2012-04-27 16:37 ` Wolfram Sang
2012-04-28 3:03 ` [TEST PATCH] mxs-i2c DMA support Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204271753.39516.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).