From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Sat, 28 Apr 2012 12:26:01 +0200 Subject: [PATCH] i2c: mxs: disable QUEUE when sending is done In-Reply-To: References: <1335536631-28202-1-git-send-email-w.sang@pengutronix.de> Message-ID: <20120428102601.GO20039@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Apr 27, 2012 at 11:51:56AM -0300, Fabio Estevam wrote: > Hi Wolfram, > > On Fri, Apr 27, 2012 at 11:23 AM, Wolfram Sang wrote: > > > ? ? ? ?if (i2c->cmd_err == -ENXIO) > > ? ? ? ? ? ? ? ?mxs_i2c_reset(i2c); > > + ? ? ? else > > + ? ? ? ? ? ? ? writel(MXS_I2C_QUEUECTRL_QUEUE_RUN, > > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? i2c->regs + MXS_I2C_QUEUECTRL_CLR); > > When setting the QUEUE_RUN, do we really want to clear all the other > bits of QUEUECTRL_CLR register? > > I am wondering if we should only set QUEUE_RUN bit here. I didn't check the manual, but I guess writing to MXS_I2C_QUEUECTRL_CLR just clears the QUEUE_RUN bit and nothing else?! Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |