From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: mxs: disable QUEUE when sending is done
Date: Sun, 29 Apr 2012 11:11:13 +0200 [thread overview]
Message-ID: <201204291111.13333.marex@denx.de> (raw)
In-Reply-To: <20120429084324.GA3001@pengutronix.de>
Dear Wolfram Sang,
> > > > I am wondering if we should only set QUEUE_RUN bit here.
> > >
> > > I didn't check the manual, but I guess writing to MXS_I2C_QUEUECTRL_CLR
> > > just clears the QUEUE_RUN bit and nothing else?!
> >
> > I think the RUN bit will be cleared by the controller anyway, so this
> > patch is pointless.
>
> How do you get this idea? Given 27.3.2 and our experiences, I'd be very
> surprised. Try putting the system under heavy load without this patch
> and you'll see that FIFOs might be sent half filled when interrupted
> while filling.
All right, I won't argue here ;-)
Best regards,
Marek Vasut
prev parent reply other threads:[~2012-04-29 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 14:23 [PATCH] i2c: mxs: disable QUEUE when sending is done Wolfram Sang
2012-04-27 14:51 ` Fabio Estevam
2012-04-28 10:26 ` Uwe Kleine-König
2012-04-28 13:33 ` Marek Vasut
2012-04-29 8:43 ` Wolfram Sang
2012-04-29 9:11 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204291111.13333.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).