linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] I2C: Implement DMA support into mxs-i2c
Date: Mon, 30 Apr 2012 22:45:57 +0200	[thread overview]
Message-ID: <201204302245.57958.marex@denx.de> (raw)
In-Reply-To: <20120430203016.GD28226@pengutronix.de>

Dear Wolfram Sang,

> > > What has the compiler version to do with the relevance? :) This has
> > > nothing to do with adding DMA support. Plus, nobody so far could tell
> > > me what path gcc is seeing there.
> > 
> > It complains that data might be undefined, do you want it in a separate
> > patch then ?
> 
> Yes, but only if you can prove that the compiler is right.

It's not right, because that variable is always initialized, but this at least 
squashes the compile warning.

> > I still havent figured out how to flip between pioqueue mode and dma mode
> > without the controller getting confused, so I prefer to postpone it into
> > subsequent patch. Eventually, I agree it'd be cool to be able to do this
> > switching.
> 
> Yes, send V2 with DMA by default, and I will give a try on the
> mode-switching later, too.

I'd prefer to have PIOQ by default, to avoid breaking some of the boards. Or can 
you test on all of them?

> 
> Thanks,
> 
>    Wolfram

Best regards,
Marek Vasut

  reply	other threads:[~2012-04-30 20:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-29 22:36 [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Marek Vasut
2012-04-29 22:36 ` [PATCH 2/2] I2C: Implement DMA support into mxs-i2c Marek Vasut
2012-04-30  6:05   ` Wolfram Sang
2012-04-30 12:10     ` Marek Vasut
2012-04-30 19:52       ` Wolfram Sang
2012-04-30 20:07         ` Marek Vasut
2012-04-30 20:30           ` Wolfram Sang
2012-04-30 20:45             ` Marek Vasut [this message]
2012-04-30 21:01               ` Wolfram Sang
2012-04-30 21:19                 ` Marek Vasut
2012-05-01 13:58                 ` Shawn Guo
2012-05-01 14:02                   ` Marek Vasut
2012-05-01 14:09                     ` Shawn Guo
2012-05-01 14:14                       ` Marek Vasut
2012-05-01 14:37                   ` Russell King - ARM Linux
2012-04-30  5:58 ` [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Wolfram Sang
2012-04-30 12:05   ` Marek Vasut
2012-04-30 19:43     ` Wolfram Sang
2012-04-30 20:09       ` Marek Vasut
2012-04-30 20:27         ` Wolfram Sang
2012-04-30 20:47           ` Marek Vasut
2012-04-30 21:02             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204302245.57958.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).