linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c
Date: Mon, 30 Apr 2012 22:47:17 +0200	[thread overview]
Message-ID: <201204302247.17242.marex@denx.de> (raw)
In-Reply-To: <20120430202742.GC28226@pengutronix.de>

Dear Wolfram Sang,

> > > > > > This sets the bus to run at 400kHz, prior to this,
> > > > > > the bus frequency was undefined.
> > > > > 
> > > > > Not exactly. The default values let it run at 100kHz.
> > > > 
> > > > Have you tried dumping the default values and comparing it with the
> > > > values for 100kHz in the manual?
> > > 
> > > Yes, sure. Doesn't it work for you? I just rechecked and the values are
> > > okay. That being said, if you make it configurable for 400kHz, it would
> > > in deed be better to rewrite the values for 100kHz, too.
> > 
> > They were different for me ... did you configure the i2c bus in your
> > bootloader possibly? Those values might have been written there since
> > then ... I didn't run i2c in u-boot before booting linux.
> 
> Nope, no I2C involved in the bootloader at all. Do you get the correct
> values after soft-resetting the device?
> 
> It doesn't really matter, though. Just reinit them to the proper values
> depending on the user setting.

Indeed. Default to 100kHz might be a good idea too, in case user entered some 
weird value. Eventually, it'd be nice if we could calculate the timing values 
for all possible frequencies, but I didn't got to deriving such formula ... 
dunno if it's worth it either, doubt so.

Best regards,
Marek Vasut

  reply	other threads:[~2012-04-30 20:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-29 22:36 [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Marek Vasut
2012-04-29 22:36 ` [PATCH 2/2] I2C: Implement DMA support into mxs-i2c Marek Vasut
2012-04-30  6:05   ` Wolfram Sang
2012-04-30 12:10     ` Marek Vasut
2012-04-30 19:52       ` Wolfram Sang
2012-04-30 20:07         ` Marek Vasut
2012-04-30 20:30           ` Wolfram Sang
2012-04-30 20:45             ` Marek Vasut
2012-04-30 21:01               ` Wolfram Sang
2012-04-30 21:19                 ` Marek Vasut
2012-05-01 13:58                 ` Shawn Guo
2012-05-01 14:02                   ` Marek Vasut
2012-05-01 14:09                     ` Shawn Guo
2012-05-01 14:14                       ` Marek Vasut
2012-05-01 14:37                   ` Russell King - ARM Linux
2012-04-30  5:58 ` [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Wolfram Sang
2012-04-30 12:05   ` Marek Vasut
2012-04-30 19:43     ` Wolfram Sang
2012-04-30 20:09       ` Marek Vasut
2012-04-30 20:27         ` Wolfram Sang
2012-04-30 20:47           ` Marek Vasut [this message]
2012-04-30 21:02             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204302247.17242.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).