From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 00/11 V7] MXS: Add i.MX28 USB Host driver
Date: Tue, 1 May 2012 15:55:48 +0200 [thread overview]
Message-ID: <201205011555.48430.marex@denx.de> (raw)
In-Reply-To: <F281D0F91ED19E4D8E63A7504E8A649803B7C53C@039-SN2MPN1-023.039d.mgd.msft.net>
Dear Chen Peter-B29397,
> > Well, let's fix it in V8. I suggest we do a stub handler in the ehci-mxs
> > for
> > usb_add_hcd() and call ehci_irq() from the imx-otg's IRQ handler like
> > it's
> > already done in this patchset.
>
> I have not understood how you would like to do?
Still use IRQF_SHARED for the usb interrupt, but:
* The IRQ handler in ehci-mxs, that's set in hc_driver.irq would be always
returning IRQ_NONE.
* The IRQ handler in imx-otg would call the callback registered via
imx_otg_set_irq_handler() only if the port was actually in host mode
>
> > But this patchset also works with the host-only port #1 on mx28
> > (obviously, you
> > can't enable gadget(device) mode for that port).
>
> Currently, there is not generic PHY driver, so only one PHY can be
> supported at runtime, and only one controller can be enabled if you have
> used PHY driver.
Correct
> How can you let otg and host 1 work together with your patchset?
Sorry for not being clear enough, what I mean was that this patchset supports:
* Port0 in both Device and Host mode (separately, configured via platform data)
* Port1 in Host mode
And that Port0 and Port1 can NOT be enabled at the same time, so the above is
mutually exclusive.
> > > Understanding your scope may help me review your patches.
> > >
> > > > Best regards,
> > > > Marek Vasut
> >
> > Best regards,
> > Marek Vasut
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-01 13:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 1:55 [RFC PATCH 00/11 V7] MXS: Add i.MX28 USB Host driver Marek Vasut
2012-05-01 1:55 ` [PATCH 01/11] MXS: Make clk_disable return integer Marek Vasut
2012-05-01 1:55 ` [PATCH 02/11] MXS: Add USB EHCI and USB PHY clock handling Marek Vasut
2012-05-01 1:55 ` [PATCH 03/11] MXS: Fixup i.MX233 USB base address name Marek Vasut
2012-05-01 1:55 ` [PATCH 04/11] MXS: Add data shared between imx-otg and EHCI driver Marek Vasut
2012-05-01 1:55 ` [PATCH 05/11] MXS: Modify the ci13xxx_udc to avoid adding UDC Marek Vasut
2012-05-01 1:55 ` [PATCH 06/11] MXS: Add small registration glue for ci13xxx_udc Marek Vasut
2012-05-01 1:55 ` [PATCH 07/11] MXS: Add separate MXS EHCI HCD driver Marek Vasut
2012-05-01 1:56 ` [PATCH 08/11] MXS: Add imx-otg driver Marek Vasut
2012-05-01 1:56 ` [PATCH 09/11] MXS: Add USB PHY driver Marek Vasut
2012-05-01 1:56 ` [PATCH 10/11] MXS: Add platform registration hooks for USB EHCI Marek Vasut
2012-05-01 1:56 ` [PATCH 11/11] MXS: Enable USB on M28EVK Marek Vasut
2012-05-01 3:13 ` [RFC PATCH 00/11 V7] MXS: Add i.MX28 USB Host driver Chen Peter-B29397
2012-05-01 3:21 ` Marek Vasut
2012-05-01 3:36 ` Chen Peter-B29397
2012-05-01 3:49 ` Marek Vasut
2012-05-01 7:52 ` Chen Peter-B29397
2012-05-01 13:55 ` Marek Vasut [this message]
2012-05-03 3:24 ` Chen Peter-B29397
2012-05-03 13:27 ` Marek Vasut
2012-05-09 3:29 ` Chen Peter-B29397
2012-05-09 8:43 ` Marek Vasut
2012-05-09 10:19 ` Chen Peter-B29397
2012-05-09 10:31 ` Marek Vasut
2012-05-08 0:58 ` Marek Vasut
2012-05-10 10:19 ` Juergen Beisert
2012-05-10 18:10 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205011555.48430.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).