From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] I2C: Implement DMA support into mxs-i2c
Date: Tue, 1 May 2012 16:14:01 +0200 [thread overview]
Message-ID: <201205011614.02140.marex@denx.de> (raw)
In-Reply-To: <20120501140910.GM2194@S2101-09.ap.freescale.net>
Dear Shawn Guo,
> On Tue, May 01, 2012 at 04:02:56PM +0200, Marek Vasut wrote:
> > Dear Shawn Guo,
> >
> > > On Mon, Apr 30, 2012 at 11:01:08PM +0200, Wolfram Sang wrote:
> > > > > > > It complains that data might be undefined, do you want it in a
> > > > > > > separate patch then ?
> > > > > >
> > > > > > Yes, but only if you can prove that the compiler is right.
> > > > >
> > > > > It's not right, because that variable is always initialized, but
> > > > > this at least squashes the compile warning.
> > > >
> > > > The compiler needs to be fixed, not the kernel.
> >
> > I second this.
>
> I agree on this too.
>
> > > Heh, this is coming up again. I'm not convincing you to take the
> > > change, but just curious what if this is not a compile warning but
> > > an error for the same cause that compiler is not right.
> >
> > Can you elaborate?
>
> Will we have the kernel not compilable for a few cycles until the
> compiler fixing is available, or we work it around to keep kernel
> compiling and working before we have the compiler fixed?
This is kind of lacmus paper showing if the compiler was fixed. On the other
hand, many people won't have a fixed compiler for a long time, so I'd be for
applying this patch.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-01 14:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 22:36 [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Marek Vasut
2012-04-29 22:36 ` [PATCH 2/2] I2C: Implement DMA support into mxs-i2c Marek Vasut
2012-04-30 6:05 ` Wolfram Sang
2012-04-30 12:10 ` Marek Vasut
2012-04-30 19:52 ` Wolfram Sang
2012-04-30 20:07 ` Marek Vasut
2012-04-30 20:30 ` Wolfram Sang
2012-04-30 20:45 ` Marek Vasut
2012-04-30 21:01 ` Wolfram Sang
2012-04-30 21:19 ` Marek Vasut
2012-05-01 13:58 ` Shawn Guo
2012-05-01 14:02 ` Marek Vasut
2012-05-01 14:09 ` Shawn Guo
2012-05-01 14:14 ` Marek Vasut [this message]
2012-05-01 14:37 ` Russell King - ARM Linux
2012-04-30 5:58 ` [PATCH 1/2] I2C: Set I2C timing registers for mxs-i2c Wolfram Sang
2012-04-30 12:05 ` Marek Vasut
2012-04-30 19:43 ` Wolfram Sang
2012-04-30 20:09 ` Marek Vasut
2012-04-30 20:27 ` Wolfram Sang
2012-04-30 20:47 ` Marek Vasut
2012-04-30 21:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205011614.02140.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).