linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-V6 1/3] ARM: OMAP1: FIX: check possible error condition in timer_init
Date: Fri, 4 May 2012 10:43:02 -0700	[thread overview]
Message-ID: <20120504174301.GH5613@atomide.com> (raw)
In-Reply-To: <87y5pafis6.fsf@ti.com>

Hi,

* Kevin Hilman <khilman@ti.com> [120502 13:11]:
> Vaibhav Hiremath <hvaibhav@ti.com> writes:
> 
> > OMAP1, omap_32k_timer_init() function always returns "true",
> > irrespective of whether error occurred while initializing 32k sync
> > counter as a kernel clocksource or not and execution will never
> > fallback to mpu_timer clocksource init code.
> >
> > This patch adds check for return value from function
> > omap_init_clocksource_32k(), and fallback to omap_mpu_timer_init()
> > in case of failure/error from omap_init_clocksource_32k().
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Kevin Hilman <khilman@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Benoit Cousson <b-cousson@ti.com>
> > ---
> > This is new patch addition compared to original series (<=V5).
> >
> > Also, note that, this patch is only compile tested, since
> > I do not have omap1 board with me to validate it.
> > Kevin, can you help me to validate it.
> 
> I boot tested on OMAP1 (5912/OSK) with 32k timer and MPU timer
> Kconfigs.  Works fine, but needs small change below for compile warnings.
> 
> Otherwise, looks good.

We need at least one tested-by on some 15xx platform for these changes.
Janusz, can you please give this series a try on your board too?

Regards,

Tony

  reply	other threads:[~2012-05-04 17:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-02 13:56 [PATCH-V6 0/3] ARM: OMAP: Make OMAP clocksource source selection runtime Vaibhav Hiremath
2012-05-02 13:56 ` [PATCH-V6 1/3] ARM: OMAP1: FIX: check possible error condition in timer_init Vaibhav Hiremath
2012-05-02 20:08   ` Kevin Hilman
2012-05-04 17:43     ` Tony Lindgren [this message]
2012-05-04 19:45       ` Janusz Krzysztofik
2012-05-02 13:56 ` [PATCH-V6 2/3] ARM: OMAP2+: Replace space=>underscore in the name field of system timers Vaibhav Hiremath
2012-05-02 20:09   ` Kevin Hilman
2012-05-02 13:56 ` [PATCH-V6 3/3] ARM: OMAP: Make OMAP clocksource source selection using kernel param Vaibhav Hiremath
2012-05-02 20:39   ` Kevin Hilman
2012-05-03  8:06     ` Hiremath, Vaibhav
2012-05-02 19:56 ` [PATCH-V6 0/3] ARM: OMAP: Make OMAP clocksource source selection runtime Jon Hunter
2012-05-03  5:07   ` Hiremath, Vaibhav
2012-05-03 18:19     ` Jon Hunter
2012-05-07 12:39       ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120504174301.GH5613@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).