From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] dma: mxs-dma: make platform_device_id more generic
Date: Sat, 5 May 2012 16:32:14 +0200 [thread overview]
Message-ID: <201205051632.14882.marex@denx.de> (raw)
In-Reply-To: <CAAQ0ZWTztNaqwjVA257N+42PByhH1k1Gswi18S9G=dHEaO5PhQ@mail.gmail.com>
Dear Shawn Guo,
> On 5 May 2012 21:12, Marek Vasut <marex@denx.de> wrote:
> > Can't the patches be reordered then to avoid adding this altogether?
>
> Maybe. But I do not think it's really worth the effort.
>
> > You don't have to add dead code in this patch and re-add it when needed.
> > Or fix the macro to take the parameter then, though I don't understand
> > why you'd want to take it and then hide it.
>
> I do not completely understand the comment. My point is the problem
> is in the existing code. It's not introduced by Dong's patch. The
> problem should be fixed in another patch, and we do not want to do
> several things in one patch.
Then order such a patch before Dong's series then? It'd all be clear, without
compromises.
>
> Regards,
> Shawn
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-05 14:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 12:12 [PATCH v2 1/5] dma: mxs-dma: use global stmp_device functionality Dong Aisheng
2012-05-04 12:12 ` [PATCH v2 2/5] dma: mxs-dma: make platform_device_id more generic Dong Aisheng
2012-05-04 12:15 ` Marek Vasut
2012-05-04 14:34 ` Shawn Guo
2012-05-05 13:12 ` Marek Vasut
2012-05-05 13:25 ` Shawn Guo
2012-05-05 14:32 ` Marek Vasut [this message]
2012-05-07 3:55 ` Dong Aisheng
2012-05-07 3:52 ` Shawn Guo
2012-05-07 4:07 ` Marek Vasut
2012-05-07 4:14 ` Shawn Guo
2012-05-04 12:12 ` [PATCH v2 3/5] dma: mxs-dma: add device tree probe support Dong Aisheng
2012-05-04 12:12 ` [PATCH v2 4/5] ARM: mxs: do not add dma device by default Dong Aisheng
2012-05-04 12:12 ` [PATCH v2 5/5] ARM: mx28evk: add mxs-dma dt support Dong Aisheng
2012-05-04 14:44 ` [PATCH v2 1/5] dma: mxs-dma: use global stmp_device functionality Shawn Guo
2012-05-07 3:20 ` Dong Aisheng
2012-05-04 16:02 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205051632.14882.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).