From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Mon, 7 May 2012 10:34:30 -0700 Subject: [PATCH 07/13] ARM: OMAP5: l3: Add l3 error handler support for omap5. In-Reply-To: References: <1336029982-31898-1-git-send-email-r.sricharan@ti.com> <1336029982-31898-8-git-send-email-r.sricharan@ti.com> <20120504225153.GZ5613@atomide.com> Message-ID: <20120507173430.GC5088@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * R, Sricharan [120506 00:42]: > Hi Tony, > > >> - ? ? if (!(cpu_is_omap44xx())) > >> + ? ? if ((!(cpu_is_omap44xx())) && (!cpu_is_omap54xx())) > >> ? ? ? ? ? ? ? return -ENODEV; > >> > >> ? ? ? for (i = 0; i < L3_MODULES; i++) { > > > > Isn't there some unnecessary parens here? > > You mean in this above for loop?. > There are multiple statements . No, both the old (!(cpu_is_omap44xx())) and the added one. Tony