* [PATCH] mfd: da9052: fix of_match_node() arguments
@ 2012-05-05 23:02 Olof Johansson
2012-05-08 17:00 ` Ying-Chun Liu (PaulLiu)
2012-05-09 14:10 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Olof Johansson @ 2012-05-05 23:02 UTC (permalink / raw)
To: linux-arm-kernel
The driver calls of_match_node() with the arguments swapped.
Signed-off-by: Olof Johansson <olof@lixom.net>
---
drivers/mfd/da9052-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
index d8abdb3..8410065 100644
--- a/drivers/mfd/da9052-i2c.c
+++ b/drivers/mfd/da9052-i2c.c
@@ -104,7 +104,7 @@ static int __devinit da9052_i2c_probe(struct i2c_client *client,
struct device_node *np = client->dev.of_node;
const struct of_device_id *deviceid;
- deviceid = of_match_node(np, dialog_dt_ids);
+ deviceid = of_match_node(dialog_dt_ids, np);
id = (const struct i2c_device_id *)deviceid->data;
}
#endif
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] mfd: da9052: fix of_match_node() arguments
2012-05-05 23:02 [PATCH] mfd: da9052: fix of_match_node() arguments Olof Johansson
@ 2012-05-08 17:00 ` Ying-Chun Liu (PaulLiu)
2012-05-09 14:10 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Ying-Chun Liu (PaulLiu) @ 2012-05-08 17:00 UTC (permalink / raw)
To: linux-arm-kernel
(2012?05?06? 07:02), Olof Johansson wrote:
> The driver calls of_match_node() with the arguments swapped.
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> drivers/mfd/da9052-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index d8abdb3..8410065 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -104,7 +104,7 @@ static int __devinit da9052_i2c_probe(struct i2c_client *client,
> struct device_node *np = client->dev.of_node;
> const struct of_device_id *deviceid;
>
> - deviceid = of_match_node(np, dialog_dt_ids);
> + deviceid = of_match_node(dialog_dt_ids, np);
> id = (const struct i2c_device_id *)deviceid->data;
> }
> #endif
Tested-by: Ying-Chun Liu <paul.liu@linaro.org>
Sorry. I don't know how my code works and tested previously.
But your patch is definited correct.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mfd: da9052: fix of_match_node() arguments
2012-05-05 23:02 [PATCH] mfd: da9052: fix of_match_node() arguments Olof Johansson
2012-05-08 17:00 ` Ying-Chun Liu (PaulLiu)
@ 2012-05-09 14:10 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-05-09 14:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi Olof,
On Sat, May 05, 2012 at 04:02:48PM -0700, Olof Johansson wrote:
> The driver calls of_match_node() with the arguments swapped.
Thanks, patch applied to my for-next branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-09 14:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-05 23:02 [PATCH] mfd: da9052: fix of_match_node() arguments Olof Johansson
2012-05-08 17:00 ` Ying-Chun Liu (PaulLiu)
2012-05-09 14:10 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).