linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] omap fixes for v3.4-rc6
Date: Wed, 9 May 2012 08:15:11 -0700	[thread overview]
Message-ID: <20120509151510.GG5088@atomide.com> (raw)
In-Reply-To: <1673508.aX9Ao89479@avalon>

* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [120509 04:09]:
> Hi Olof,
> 
> On Tuesday 08 May 2012 23:48:06 Olof Johansson wrote:
> > Hi,
> > 
> > On Mon, May 7, 2012 at 3:36 PM, Tony Lindgren <tony@atomide.com> wrote:
> > > The following changes since commit 
> 69964ea4c7b68c9399f7977aa5b9aa6539a6a98a:
> > [..]
> > 
> > > Enrico Butera (1):
> > >      ARM: OMAP: igep0020: fix smsc911x dummy regulator id
> > 
> > Hmm. Picking 40 without any kind of comment in the code isn't doing
> > any favors for future readers. Seems like 1 would be free on this
> > board, from the rest of the board file to judge (one other
> > reg-fixed-regulator platform device)?
> > 
> > Please either comment why you picked 40 (i.e. it's a random number),
> > or change it to something a little less random like 1. :)

I'll use the update patch from Enrico.

> > > Laurent Pinchart (1):
> > >      ARM: OMAP: igep0020: Specify the VPLL2 regulator unconditionally
> > 
> > Is this a regression? I don't see any recent changes regarding this,
> > so it's hard to tell. If not then I'd rather hold off for the merge
> > window given that we're at -rc6.
> 
> It's not a regression, I'm fine with holding off until the v3.5 merge window.

And will move this one into fixes-non-critical.

Will send a new pull request shortly.

Tony

      reply	other threads:[~2012-05-09 15:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07 22:36 [GIT PULL] omap fixes for v3.4-rc6 Tony Lindgren
2012-05-09  6:48 ` Olof Johansson
2012-05-09  8:32   ` Enrico
2012-05-09 11:05   ` Laurent Pinchart
2012-05-09 15:15     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120509151510.GG5088@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).