From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: remove incorrect irq_chip ack field
Date: Wed, 9 May 2012 10:36:06 -0700 [thread overview]
Message-ID: <20120509173605.GS5088@atomide.com> (raw)
In-Reply-To: <1336262212-4455-1-git-send-email-notasas@gmail.com>
* Grazvydas Ignotas <notasas@gmail.com> [120505 17:00]:
> Each irq_chip for the main interrupt controller has offsets set for irq
> masking registers, which added to respective base results in a pointer
> to appropriate hardware register. However this is not correct for
> INTC_CONTROL as there is only one INTC_CONTROL register. This does not
> cause problems because generic ack code is never called, but remove
> this assignment to avoid confusion.
Thanks applying into fixes-non-critical.
Regards,
Tony
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
> arch/arm/mach-omap2/irq.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index 65f0d25..c11e8a8 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -149,7 +149,6 @@ omap_alloc_gc(void __iomem *base, unsigned int irq_start, unsigned int num)
> ct->chip.irq_mask = irq_gc_mask_disable_reg;
> ct->chip.irq_unmask = irq_gc_unmask_enable_reg;
>
> - ct->regs.ack = INTC_CONTROL;
> ct->regs.enable = INTC_MIR_CLEAR0;
> ct->regs.disable = INTC_MIR_SET0;
> irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE,
> --
> 1.7.0.4
>
prev parent reply other threads:[~2012-05-09 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 23:56 [PATCH] ARM: OMAP2+: remove incorrect irq_chip ack field Grazvydas Ignotas
2012-05-09 17:36 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509173605.GS5088@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).