From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] mmc: dw_mmc: lookup for optional biu and ciu clocks
Date: Thu, 10 May 2012 14:43:42 +0100 [thread overview]
Message-ID: <20120510134342.GA12727@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAAG0J9-NDM9wLKpq04ofPkvFqiWxjmP84ojsP9Hfs0SJ_0FaXg@mail.gmail.com>
On Wed, May 02, 2012 at 03:53:53PM +0100, James Hogan wrote:
> Hi
>
> On 2 May 2012 06:07, Thomas Abraham <thomas.abraham@linaro.org> wrote:
> > + ? ? ? if (IS_ERR(host->biu_clk))
> > + ? ? ? ? ? ? ? dev_info(&host->dev, "biu clock not available\n");
>
> In this case, should it set host->biu_clk to NULL or are clk_disable
> and clk_put guaranteed to handle an IS_ERR value?
I keep saying this. NULL must be treated as a valid reutrn value from
clk_get() and must not use this as a sentinel. The clk namespace is
that errors are indicated with IS_ERR(clk) returning true. Everything
else must be assumed to be valid by drivers.
next prev parent reply other threads:[~2012-05-10 13:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 5:07 [PATCH 0/7] mmc: dw_mmc: add support for device tree based instantiation Thomas Abraham
2012-05-02 5:07 ` [PATCH 1/7] mmc: dw_mmc: lookup for optional biu and ciu clocks Thomas Abraham
2012-05-02 9:17 ` Will Newton
2012-05-10 9:11 ` Thomas Abraham
2012-05-02 9:53 ` Russell King - ARM Linux
2012-05-10 9:12 ` Thomas Abraham
2012-05-02 14:53 ` James Hogan
2012-05-10 9:20 ` Thomas Abraham
2012-05-10 13:43 ` Russell King - ARM Linux [this message]
2012-05-02 5:07 ` [PATCH 2/7] mmc: dw_mmc: add quirk to indicate missing write protect line Thomas Abraham
2012-05-02 9:10 ` Will Newton
2012-05-02 5:07 ` [PATCH 3/7] mmc: dw_mmc: add device tree support Thomas Abraham
2012-05-02 6:55 ` Kyungmin Park
2012-05-10 9:42 ` Thomas Abraham
2012-05-10 9:59 ` Kyungmin Park
2012-05-10 10:12 ` Thomas Abraham
2012-05-02 18:07 ` Olof Johansson
2012-05-10 10:15 ` Thomas Abraham
2012-05-12 7:07 ` Olof Johansson
2012-05-12 8:43 ` Thomas Abraham
2012-05-03 22:48 ` Guennadi Liakhovetski
2012-05-12 7:01 ` Thomas Abraham
2012-05-12 19:31 ` Guennadi Liakhovetski
2012-05-17 15:39 ` Thomas Abraham
2012-05-10 10:32 ` James Hogan
2012-05-10 10:44 ` Thomas Abraham
2012-05-02 5:07 ` [PATCH 4/7] mmc: dw_mmc: add samsung exynos5250 specific extentions Thomas Abraham
2012-05-02 7:01 ` Kyungmin Park
2012-05-02 7:49 ` Jaehoon Chung
2012-05-10 10:55 ` Thomas Abraham
2012-05-10 11:17 ` Jaehoon Chung
2012-05-10 10:38 ` Thomas Abraham
2012-05-02 18:10 ` Olof Johansson
2012-05-10 10:55 ` Thomas Abraham
2012-05-02 5:07 ` [PATCH 5/7] ARM: Samsung: Add support for MSHC controller clocks Thomas Abraham
2012-05-02 7:04 ` Kyungmin Park
2012-05-02 5:07 ` [PATCH 6/7] ARM: Exynos5: Add AUXDATA support for MSHC controllers Thomas Abraham
2012-05-02 5:07 ` [PATCH 7/7] ARM: dts: Add nodes for dw_mmc controllers for Samsung Exynos5250 platforms Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510134342.GA12727@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).