From: shiraz.hashim@st.com (Shiraz Hashim)
To: linux-arm-kernel@lists.infradead.org
Subject: smp_twd fix for adapting to cpu frequency change
Date: Fri, 11 May 2012 14:51:05 +0530 [thread overview]
Message-ID: <20120511092105.GR30029@localhost.localdomain> (raw)
In-Reply-To: <CACRpkdZzAO4hAJKyAoeqnud9LeDG4nSK7y9cLZaEBdVOnq-ocw@mail.gmail.com>
Hi Linus,
On Tue, May 08, 2012 at 07:33:56PM +0800, Linus Walleij wrote:
> Can you test this snippet?
> Thomas: does this look sane?
>
> >From d40c3c3302a2f89ab973b41b350153c144f6bded Mon Sep 17 00:00:00 2001
> From: Linus Walleij <linus.walleij@linaro.org>
> Date: Tue, 8 May 2012 13:26:43 +0200
> Subject: [PATCH] ARM: smp_twd: reprogram loadvalue for periodic event
>
> The code to handle frequency transitions of the TWD only
> handle one-shot events. Let's try to account for this by
> checking the state of the event.
>
> Reported-by: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> arch/arm/kernel/smp_twd.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
> index fef42b2..98b27e6 100644
> --- a/arch/arm/kernel/smp_twd.c
> +++ b/arch/arm/kernel/smp_twd.c
> @@ -104,9 +104,17 @@ static void twd_timer_stop(struct clock_event_device *clk)
> */
> static void twd_update_frequency(void *data)
> {
> + struct clock_event_device *evt = *__this_cpu_ptr(twd_evt);
> +
> twd_timer_rate = clk_get_rate(twd_clk);
>
> - clockevents_update_freq(*__this_cpu_ptr(twd_evt), twd_timer_rate);
> + /* If we're in periodic mode, just put in a new load value */
> + if (evt->mode == CLOCK_EVT_MODE_PERIODIC) {
> + __raw_writel(twd_timer_rate / HZ, twd_base + TWD_TIMER_LOAD);
> + return;
> + }
> +
> + clockevents_update_freq(evt, twd_timer_rate);
> }
>
> static int twd_cpufreq_transition(struct notifier_block *nb,
> --
Thanks, it works.
--
regards
Shiraz
next prev parent reply other threads:[~2012-05-11 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 11:15 smp_twd fix for adapting to cpu frequency change shiraz hashim
2012-05-08 11:33 ` Linus Walleij
2012-05-08 11:40 ` Thomas Gleixner
2012-05-11 9:21 ` Shiraz Hashim [this message]
2012-05-11 12:46 ` Linus Walleij
2015-05-14 14:44 ` Viresh Kumar
2015-05-14 14:48 ` Russell King - ARM Linux
2015-05-15 3:24 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511092105.GR30029@localhost.localdomain \
--to=shiraz.hashim@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).