From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init
Date: Fri, 11 May 2012 12:57:45 -0600 [thread overview]
Message-ID: <20120511185745.558333E0791@localhost> (raw)
In-Reply-To: <87mx5gm7wj.fsf@ti.com>
On Thu, 10 May 2012 07:23:56 -0700, Kevin Hilman <khilman@ti.com> wrote:
> Grant,
>
> "DebBarma, Tarun Kanti" <tarun.kanti@ti.com> writes:
>
> > Hi,
> >
> > On Thu, May 10, 2012 at 3:06 AM, Janusz Krzysztofik
> > <jkrzyszt@tis.icnet.pl> wrote:
> >> On Mon, 7 May 2012 10:52:28 DebBarma, Tarun Kanti wrote:
> >>> On Sun, May 6, 2012 at 3:25 AM, Grazvydas Ignotas <notasas@gmail.com> wrote:
> >>> > On Mon, Apr 30, 2012 at 10:20 AM, Tarun Kanti DebBarma
> >>> > <tarun.kanti@ti.com> wrote:
> >>> >> Initialization of irqenable, irqstatus registers is the common
> >>> >> operation done in this function for all OMAP platforms, viz. OMAP1,
> >>> >> OMAP2+. The latter _gpio_rmw()'s which supposedly got introduced
> >>> >> wrongly to take care of OMAP2+ platforms were overwriting initially
> >>> >> programmed OMAP1 value breaking functionality on OMAP1.
> >>
> >> Hi,
> >> I can confirm that my other issues with GPIO on Amstrad Delta were not
> >> related, and this patch is still required for GPIO interrupts hardware
> >> being correctly initialized on OMAP1 in 3.4-rc6. You can add my
> >>
> >> Tested-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> >>
> >> if you wish.
> > Thank you for confirming!!
>
> We'd like to get this one in for v3.4-rc. Can you queue it?
>
> I added the tested-by from Janusz and my signoff, and pull request is
> below.
Pulled, thanks. I'll send a pull req out to Linus today.
g.
next prev parent reply other threads:[~2012-05-11 18:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 7:20 [PATCH v2] gpio/omap: fix incorrect initialization of omap_gpio_mod_init Tarun Kanti DebBarma
2012-05-05 21:55 ` Grazvydas Ignotas
2012-05-07 5:22 ` DebBarma, Tarun Kanti
2012-05-09 21:36 ` Janusz Krzysztofik
2012-05-10 5:15 ` DebBarma, Tarun Kanti
2012-05-10 14:23 ` Kevin Hilman
2012-05-11 18:57 ` Grant Likely [this message]
2012-05-11 18:58 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511185745.558333E0791@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).