* [PATCH] ARM: integrator: fix typo in PCI swizzle function
@ 2012-05-12 9:05 Linus Walleij
2012-05-12 9:40 ` Russell King - ARM Linux
2012-05-13 16:04 ` Paul Gortmaker
0 siblings, 2 replies; 6+ messages in thread
From: Linus Walleij @ 2012-05-12 9:05 UTC (permalink / raw)
To: linux-arm-kernel
The next tree didn't compile due to a typo in commit
cfb32a689949d09f112493de4a1e3e5900db2053
"ARM: PCI: integrator: use common PCI swizzle"
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/mach-integrator/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-integrator/pci.c b/arch/arm/mach-integrator/pci.c
index 40f4b4f..6c1667e 100644
--- a/arch/arm/mach-integrator/pci.c
+++ b/arch/arm/mach-integrator/pci.c
@@ -73,7 +73,7 @@ static u8 __init integrator_swizzle(struct pci_dev *dev, u8 *pinp)
if (*pinp == 0)
*pinp = 1;
- return pci_std_swizzle(dev, pinp);
+ return pci_common_swizzle(dev, pinp);
}
static int irq_tab[4] __initdata = {
--
1.7.7.6
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: integrator: fix typo in PCI swizzle function
2012-05-12 9:05 [PATCH] ARM: integrator: fix typo in PCI swizzle function Linus Walleij
@ 2012-05-12 9:40 ` Russell King - ARM Linux
2012-05-12 23:06 ` Linus Walleij
2012-05-13 16:04 ` Paul Gortmaker
1 sibling, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2012-05-12 9:40 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, May 12, 2012 at 11:05:46AM +0200, Linus Walleij wrote:
> The next tree didn't compile due to a typo in commit
> cfb32a689949d09f112493de4a1e3e5900db2053
> "ARM: PCI: integrator: use common PCI swizzle"
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Do you want me to merge this into the original commit?
> ---
> arch/arm/mach-integrator/pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-integrator/pci.c b/arch/arm/mach-integrator/pci.c
> index 40f4b4f..6c1667e 100644
> --- a/arch/arm/mach-integrator/pci.c
> +++ b/arch/arm/mach-integrator/pci.c
> @@ -73,7 +73,7 @@ static u8 __init integrator_swizzle(struct pci_dev *dev, u8 *pinp)
> if (*pinp == 0)
> *pinp = 1;
>
> - return pci_std_swizzle(dev, pinp);
> + return pci_common_swizzle(dev, pinp);
> }
>
> static int irq_tab[4] __initdata = {
> --
> 1.7.7.6
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: integrator: fix typo in PCI swizzle function
2012-05-12 9:40 ` Russell King - ARM Linux
@ 2012-05-12 23:06 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-05-12 23:06 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, May 12, 2012 at 11:40 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Sat, May 12, 2012 at 11:05:46AM +0200, Linus Walleij wrote:
>> The next tree didn't compile due to a typo in commit
>> cfb32a689949d09f112493de4a1e3e5900db2053
>> "ARM: PCI: integrator: use common PCI swizzle"
>>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Do you want me to merge this into the original commit?
Why not, do you need it in the patch tracker or will you
just hand-edit it?
Thanks,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: integrator: fix typo in PCI swizzle function
2012-05-12 9:05 [PATCH] ARM: integrator: fix typo in PCI swizzle function Linus Walleij
2012-05-12 9:40 ` Russell King - ARM Linux
@ 2012-05-13 16:04 ` Paul Gortmaker
2012-05-13 16:09 ` Russell King - ARM Linux
1 sibling, 1 reply; 6+ messages in thread
From: Paul Gortmaker @ 2012-05-13 16:04 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, May 12, 2012 at 5:05 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> The next tree didn't compile due to a typo in commit
> cfb32a689949d09f112493de4a1e3e5900db2053
> "ARM: PCI: integrator: use common PCI swizzle"
While the above commit may have played a role, it wasn't the
one that actually caused the final build fail. I bisected to the
failing commit and sent the same fix for this over a week ago.
http://www.spinics.net/lists/arm-kernel/msg172951.html
Should I also be Cc'ing arm at kernel.org on all prospective
ARM fixes I find in linux-next in the future?
Thanks,
Paul.
---
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ?arch/arm/mach-integrator/pci.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-integrator/pci.c b/arch/arm/mach-integrator/pci.c
> index 40f4b4f..6c1667e 100644
> --- a/arch/arm/mach-integrator/pci.c
> +++ b/arch/arm/mach-integrator/pci.c
> @@ -73,7 +73,7 @@ static u8 __init integrator_swizzle(struct pci_dev *dev, u8 *pinp)
> ? ? ? ?if (*pinp == 0)
> ? ? ? ? ? ? ? ?*pinp = 1;
>
> - ? ? ? return pci_std_swizzle(dev, pinp);
> + ? ? ? return pci_common_swizzle(dev, pinp);
> ?}
>
> ?static int irq_tab[4] __initdata = {
> --
> 1.7.7.6
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: integrator: fix typo in PCI swizzle function
2012-05-13 16:04 ` Paul Gortmaker
@ 2012-05-13 16:09 ` Russell King - ARM Linux
2012-05-13 19:59 ` Paul Gortmaker
0 siblings, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2012-05-13 16:09 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, May 13, 2012 at 12:04:40PM -0400, Paul Gortmaker wrote:
> On Sat, May 12, 2012 at 5:05 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > The next tree didn't compile due to a typo in commit
> > cfb32a689949d09f112493de4a1e3e5900db2053
> > "ARM: PCI: integrator: use common PCI swizzle"
>
> While the above commit may have played a role, it wasn't the
> one that actually caused the final build fail. I bisected to the
> failing commit and sent the same fix for this over a week ago.
>
> http://www.spinics.net/lists/arm-kernel/msg172951.html
>
> Should I also be Cc'ing arm at kernel.org on all prospective
> ARM fixes I find in linux-next in the future?
Take a moment to have a think about whether arm-soc can fix a change
that's in my tree...
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: integrator: fix typo in PCI swizzle function
2012-05-13 16:09 ` Russell King - ARM Linux
@ 2012-05-13 19:59 ` Paul Gortmaker
0 siblings, 0 replies; 6+ messages in thread
From: Paul Gortmaker @ 2012-05-13 19:59 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, May 13, 2012 at 12:09 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Sun, May 13, 2012 at 12:04:40PM -0400, Paul Gortmaker wrote:
>> On Sat, May 12, 2012 at 5:05 AM, Linus Walleij <linus.walleij@linaro.org>
>> wrote:
>> > The next tree didn't compile due to a typo in commit
>> > cfb32a689949d09f112493de4a1e3e5900db2053
>> > "ARM: PCI: integrator: use common PCI swizzle"
>>
>> While the above commit may have played a role, it wasn't the
>> one that actually caused the final build fail. ?I bisected to the
>> failing commit and sent the same fix for this over a week ago.
>>
>> http://www.spinics.net/lists/arm-kernel/msg172951.html
>>
>> Should I also be Cc'ing arm at kernel.org on all prospective
>> ARM fixes I find in linux-next in the future?
>
> Take a moment to have a think about whether arm-soc can fix a change
> that's in my tree...
Yeah, good point. I just hate to see wasted/duplicated work and
was wondering if I was missing something when I just sent the
above fix to you and linux-arm-kernel vs. logging it in the patch
tracker and/or expanding the CC list in some way.
Paul.
---
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-13 19:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-12 9:05 [PATCH] ARM: integrator: fix typo in PCI swizzle function Linus Walleij
2012-05-12 9:40 ` Russell King - ARM Linux
2012-05-12 23:06 ` Linus Walleij
2012-05-13 16:04 ` Paul Gortmaker
2012-05-13 16:09 ` Russell King - ARM Linux
2012-05-13 19:59 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).