From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] dmaengine/amba-pl08x: check slave_channels to avoid kernel panic
Date: Tue, 15 May 2012 11:22:58 +0100 [thread overview]
Message-ID: <20120515102258.GI10453@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAKwPUoyYaXk3DjY8WGHZtM8j3CB2q94RQvEhD-b6FEP5W+7KFQ@mail.gmail.com>
On Tue, May 15, 2012 at 06:19:36PM +0800, Kassey Lee wrote:
> commit 58baed44d52f5e0d87aca575318d71fe3937544c
> Author: Kassey Lee <kassey1216@gmail.com>
> Date: Wed Apr 11 02:22:26 2012 +0800
>
> dmaengine/amba-pl08x: check slave_channels to avoid kernel panic
>
> slave_channels is platform dependent, it should
> be initialized by board.c, and here we need to check it
> to avoid a NULL panic.
>
> Signed-off-by: Kassey,Lee <kassey1216@gmail.com>
Why would you set pd->num_slave_channels nonzero but leave
pd->slave_channels as a NULL pointer?
That sounds like a configuration error to me.
prev parent reply other threads:[~2012-05-15 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 10:19 [PATCH V2] dmaengine/amba-pl08x: check slave_channels to avoid kernel panic Kassey Lee
2012-05-15 10:22 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515102258.GI10453@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).