From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ASoC: add imx-mc13783 sound support
Date: Tue, 15 May 2012 19:30:35 +0100 [thread overview]
Message-ID: <20120515183035.GG19592@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1337082832-9764-4-git-send-email-philippe.retornaz@epfl.ch>
On Tue, May 15, 2012 at 01:53:51PM +0200, Philippe R?tornaz wrote:
> + ret = snd_soc_dai_set_fmt(codec_dai, FMT_SSI);
> + if (ret)
> + return ret;
> +
> + ret = snd_soc_dai_set_fmt(cpu_dai, FMT_SSI);
> + if (ret)
> + return ret;
Set this in the dai_link structure. Please fix incrementally unless you
respin, same comments about apply if Samuel is OK as the CODEC driver.
> + ret = snd_soc_dai_set_sysclk(codec_dai, MC13783_CLK_CLIA, 26000000, 0);
> + if (ret)
> + return ret;
We should probably have something for this in the dai_link too but we
don't.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120515/38198701/attachment.sig>
next prev parent reply other threads:[~2012-05-15 18:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 11:53 [PATCH 0/4] MC13783 sound support Philippe Rétornaz
2012-05-15 11:53 ` [PATCH 1/4] mc13xxx: add codec platform data Philippe Rétornaz
2012-05-15 11:53 ` [PATCH 2/4] ASoC: Add mc13783 codec Philippe Rétornaz
2012-05-15 11:53 ` [PATCH 3/4] ASoC: add imx-mc13783 sound support Philippe Rétornaz
2012-05-15 11:53 ` [PATCH 4/4] mx31moboard: Add " Philippe Rétornaz
2012-05-15 18:30 ` Mark Brown [this message]
2012-05-16 10:48 ` [PATCH] ASoC: imx-mc13783 cleanup Philippe Rétornaz
2012-05-18 15:45 ` Mark Brown
2012-05-15 18:27 ` [PATCH 2/4] ASoC: Add mc13783 codec Mark Brown
2012-05-16 10:49 ` [PATCH] ASoC: mc13783 codec cleanups Philippe Rétornaz
2012-05-18 9:58 ` [PATCH 1/4] mc13xxx: add codec platform data Samuel Ortiz
2012-05-18 15:41 ` [PATCH 0/4] MC13783 sound support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515183035.GG19592@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).