From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 2/7] usb: chipidea: remove zero check of hw_ep_max
Date: Wed, 16 May 2012 13:32:50 +0800 [thread overview]
Message-ID: <20120516053248.GA22251@nchen-desktop> (raw)
In-Reply-To: <1337090303-16046-3-git-send-email-richard.zhao@freescale.com>
On Tue, May 15, 2012 at 09:58:18PM +0800, Richard Zhao wrote:
> It's 0 for host only device.
>
> Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
> ---
> drivers/usb/chipidea/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index f568b8e..15e03b3 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -195,7 +195,7 @@ static int hw_device_init(struct ci13xxx *ci, void __iomem *base)
> ffs_nr(DCCPARAMS_DEN);
> ci->hw_ep_max = reg * 2; /* cache hw ENDPT_MAX */
>
> - if (ci->hw_ep_max == 0 || ci->hw_ep_max > ENDPT_MAX)
> + if (ci->hw_ep_max > ENDPT_MAX)
> return -ENODEV;
Can you move this get hw_ep_max code to udc.c? As hw_ep_max is only used
for device driver. What do you think, Alex?
>
> dev_dbg(ci->dev, "ChipIdea HDRC found, lpm: %d; cap: %p op: %p\n",
> --
> 1.7.5.4
>
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2012-05-16 5:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 13:58 [PATCH v1 0/7] preliminary work for adding imx6q_sabrelite usb support Richard Zhao
2012-05-15 13:58 ` [PATCH v1 1/7] usb: chipidea: permit user select USB_EHCI_ROOT_HUB_TT Richard Zhao
2012-05-15 14:27 ` Marek Vasut
2012-05-15 15:19 ` Greg KH
2012-05-16 1:03 ` Marek Vasut
2012-05-15 13:58 ` [PATCH v1 2/7] usb: chipidea: remove zero check of hw_ep_max Richard Zhao
2012-05-16 1:11 ` Marek Vasut
2012-05-16 1:14 ` [PATCH] usb: chipidea: improve the validation of endpoint count Marek Vasut
2012-05-16 11:11 ` Alexander Shishkin
2012-05-16 5:32 ` Peter Chen [this message]
2012-05-16 5:46 ` [PATCH v1 2/7] usb: chipidea: remove zero check of hw_ep_max Richard Zhao
2012-05-16 10:48 ` Alexander Shishkin
2012-05-15 13:58 ` [PATCH v1 3/7] usb: chipidea: add imx on-soc utmi phy driver Richard Zhao
2012-05-16 1:20 ` Marek Vasut
2012-05-15 13:58 ` [PATCH v1 4/7] usb: chipidea: add imx driver binding Richard Zhao
2012-05-15 14:03 ` Russell King - ARM Linux
2012-05-15 14:12 ` Richard Zhao
2012-05-16 8:36 ` Richard Zhao
2012-05-16 1:22 ` Marek Vasut
2012-05-16 11:38 ` Alexander Shishkin
2012-05-16 11:58 ` Felipe Balbi
2012-05-16 13:08 ` Richard Zhao
2012-05-16 14:18 ` Alexander Shishkin
2012-05-17 2:41 ` Richard Zhao
2012-05-15 13:58 ` [PATCH v1 5/7] ARM: imx6q: correct device name of usbphy and usboh3 clock export Richard Zhao
2012-05-15 13:58 ` [PATCH v1 6/7] ARM: imx6q: add anatop initialization for usb controllers Richard Zhao
2012-05-15 13:58 ` [PATCH v1 7/7] ARM: dts: imx6q-sabrelite: add usb devices Richard Zhao
2012-05-15 14:28 ` [PATCH v1 0/7] preliminary work for adding imx6q_sabrelite usb support Marek Vasut
2012-05-15 15:21 ` Greg KH
2012-05-15 16:30 ` Marek Vasut
2012-05-16 0:37 ` Richard Zhao
2012-05-16 8:34 ` Peter Chen
2012-05-16 13:22 ` Marek Vasut
2012-05-16 15:05 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516053248.GA22251@nchen-desktop \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox