From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/7] ARM: imx: Add common imx cpuidle init functionality.
Date: Wed, 16 May 2012 19:55:15 +0200 [thread overview]
Message-ID: <20120516175515.GX30400@pengutronix.de> (raw)
In-Reply-To: <1337135616-8988-6-git-send-email-rob.lee@linaro.org>
On Tue, May 15, 2012 at 09:33:34PM -0500, Robert Lee wrote:
> Add common cpuidle init functionality that can be used by various
> imx platforms.
>
> Signed-off-by: Robert Lee <rob.lee@linaro.org>
> ---
> +
> +#ifdef CONFIG_CPU_IDLE
> +extern int imx_cpuidle_init(struct cpuidle_driver *drv);
> +#else
> +static inline int imx_cpuidle_init(struct cpuidle_driver *drv)
> +{
> + return -ENODEV;
> +}
> +#endif
You should return succesfully here. Think about it, if imx_cpuidle_init
fails you basically do nothing except maybe printing an error message
which will be irritating when it appears on a kernel with cpuidle
disabled.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-05-16 17:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 2:33 [PATCH v4 0/7] cleanup imx5 idle, add imx5/6 cpuidle Robert Lee
2012-05-16 2:33 ` [PATCH v4 1/7] ARM: imx: Modify IMX_IO_P2V macro Robert Lee
2012-05-16 2:33 ` [PATCH v4 2/7] ARM: imx: Add comments to tzic_enable_waker() Robert Lee
2012-05-16 2:33 ` [PATCH v4 3/7] ARM: imx: clean and consolidate imx5 suspend and idle code Robert Lee
2012-05-16 17:38 ` Sascha Hauer
2012-05-17 14:34 ` Rob Lee
2012-05-17 17:14 ` Sascha Hauer
2012-05-16 2:33 ` [PATCH v4 4/7] ARM: imx: Enable imx53 low power idle Robert Lee
2012-05-16 17:47 ` Sascha Hauer
2012-05-17 14:46 ` Rob Lee
2012-05-17 16:44 ` Sascha Hauer
2012-05-16 2:33 ` [PATCH v4 5/7] ARM: imx: Add common imx cpuidle init functionality Robert Lee
2012-05-16 17:55 ` Sascha Hauer [this message]
2012-05-17 14:47 ` Rob Lee
2012-05-16 2:33 ` [PATCH v4 6/7] ARM: imx: Add imx5 cpuidle Robert Lee
2012-05-16 2:33 ` [PATCH v4 7/7] ARM: imx: Add imx6q cpuidle driver Robert Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516175515.GX30400@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).