linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/generic: initialize the shadow of direction register
Date: Thu, 17 May 2012 14:39:14 -0600	[thread overview]
Message-ID: <20120517203914.411A73E0621@localhost> (raw)
In-Reply-To: <20120516161726.GE3764@S2100-06.ap.freescale.net>

On Thu, 17 May 2012 00:17:27 +0800, Shawn Guo <shawn.guo@freescale.com> wrote:
> On Wed, May 16, 2012 at 03:54:37PM +0200, Lothar Wa??mann wrote:
> > Actually I had sent a similar patch in July last year which was
> > rejected with the following reasoning:
> > 
> > | I don't know if this is a valid thing to do or not. Not every GPIO
> > | controller supports reading back the initial state from the direction
> > | register. I suspect it is better to leave initialization of the
> > | direction to the gpio controller driver itself.
> > 
> > See: http://lkml.indiana.edu/hypermail/linux/kernel/1107.0/00908.html
> > 
> > That's why I came up with the patch to gpio-mxc.c
> > 
> Thanks for the whole story, Lothar.  Hopefully, with the additional
> condition checking added, Grant would agree it's the right thing to do.
> I will send v2 of the patch to see what we get from people.

Yup, if there was some kind of conditional checking then it would be
fine.

g.

      reply	other threads:[~2012-05-17 20:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15  3:56 [PATCH] gpio/generic: initialize the shadow of direction register Shawn Guo
2012-05-15  7:17 ` Lothar Waßmann
2012-05-16  5:33   ` Shawn Guo
2012-05-16  6:53     ` Lothar Waßmann
2012-05-16  7:29       ` Shawn Guo
2012-05-16  7:34         ` Lothar Waßmann
2012-05-16 12:36           ` Shawn Guo
2012-05-16 12:48             ` Lothar Waßmann
2012-05-16 13:38               ` Shawn Guo
2012-05-16 13:33                 ` Lothar Waßmann
2012-05-16 14:07                   ` Shawn Guo
2012-05-16 14:03                     ` Lothar Waßmann
2012-05-16 16:21                       ` Shawn Guo
2012-05-16 13:54             ` Lothar Waßmann
2012-05-16 16:17               ` Shawn Guo
2012-05-17 20:39                 ` Grant Likely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120517203914.411A73E0621@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).