From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] GPMI-NAND: Define ecc.strength
Date: Mon, 21 May 2012 05:39:04 +0200 [thread overview]
Message-ID: <201205210539.04277.marex@denx.de> (raw)
In-Reply-To: <20120521034543.GD5810@S2100-06.ap.freescale.net>
Dear Shawn Guo,
> On Mon, May 21, 2012 at 04:40:09AM +0200, Marek Vasut wrote:
> > > So you are saying the issue is introduced by gpmi-nand DT conversion?
> >
> > I doubt so ...
>
> I can be very sure that you haven't looked at the gpmi-nand DT
> conversion patches at all.
>
> The bug has been there since day one. The commit cfbc855b (mtd: nand:
> add sanity check of ecc strength to nand_scan_tail()) added a BUG() to
> catch it recently.
>
> So please at least spend some time to know the real cause before
> pointing your figure to DT conversion.
Well ... since noone was really able to test the patch, noone figured out it's
broken. We can agree on that, right.
And btw. by "I doubt so ..." I means exactly that I doubt the bug was caused by
the DT conversion.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-21 3:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 1:02 [PATCH 1/4] GPMI-NAND: Define ecc.strength Marek Vasut
2012-05-21 1:02 ` [PATCH 2/4] GPMI-NAND: Fixup compile issue Marek Vasut
2012-05-21 1:16 ` Shawn Guo
2012-05-21 1:02 ` [PATCH 3/4] MXS-MMC: Move of_match_table out of CONFIG_PM Marek Vasut
2012-05-21 4:09 ` Shawn Guo
2012-05-21 3:52 ` Chris Ball
2012-05-21 4:33 ` Marek Vasut
2012-05-21 1:02 ` [PATCH 4/4] MXS-MMC: Add wp-inverted property Marek Vasut
2012-05-21 1:39 ` Shawn Guo
2012-05-21 2:38 ` Marek Vasut
2012-05-21 2:48 ` Shawn Guo
2012-05-21 3:22 ` Chris Ball
2012-05-21 3:36 ` Marek Vasut
2012-05-21 7:22 ` Lothar Waßmann
2012-05-21 17:38 ` Marek Vasut
2012-05-21 1:14 ` [PATCH 1/4] GPMI-NAND: Define ecc.strength Shawn Guo
2012-05-21 1:36 ` Marek Vasut
2012-05-21 1:41 ` Shawn Guo
2012-05-21 2:40 ` Marek Vasut
2012-05-21 3:08 ` Huang Shijie
2012-05-21 3:48 ` Marek Vasut
2012-05-21 3:45 ` Shawn Guo
2012-05-21 3:39 ` Marek Vasut [this message]
2012-05-21 2:44 ` Huang Shijie
2012-05-21 3:43 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205210539.04277.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).