From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Mon, 21 May 2012 12:58:00 -0400 Subject: [PATCH] arm: Add basic support for new Marvell Armada SoC family In-Reply-To: <20120521161131.GC24270@n2100.arm.linux.org.uk> References: <1337072084-21967-1-git-send-email-thomas.petazzoni@free-electrons.com> <20120520095502.GB25344@n2100.arm.linux.org.uk> <201205201058.38144.arnd@arndb.de> <20120520111025.GC25344@n2100.arm.linux.org.uk> <20120521013050.GL24238@titan.lakedaemon.net> <20120521093042.GE25344@n2100.arm.linux.org.uk> <20120521153559.GN24238@titan.lakedaemon.net> <20120521161131.GC24270@n2100.arm.linux.org.uk> Message-ID: <20120521165800.GR24238@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 21, 2012 at 05:11:31PM +0100, Russell King - ARM Linux wrote: > On Mon, May 21, 2012 at 11:35:59AM -0400, Jason Cooper wrote: > > mach-mvebu/'s directory tree structure could be: > > include/ # no headers > > include/mach/ # headers used by drivers, etc > > include/board/ # common headers used by legacy board files > > board/ # common source code for legacy board files > > > > The end goal being to empty and remove the board/'s and remove the other > > mach-*/ directories. > > Looking at what's in dove, kirkwood, mv78xx0 and orion5x directories, > I don't see many board specific files. The only two I can see are > leds-*.h, which are shared with platform drivers in drivers/leds. > > We have a place for this already - include/linux/platform_data. > > So I don't think we need include/board/ at all. Fair enough, we can move that. > I'd also suggest going against our current setup of not having "board/" > subdirectories in mach-*. Just name them board-foo.c. This is what we are currently doing for boards in the midst of DT conversion. In mach-kirkwood/ there is board-dt.c, and board-dreamplug.c. board-dt.c is the DT code, while board-dreamplug.c is board specific init code that hasn't been converted to DT yet. Once converted, board-dreamplug.c will disappear. This follows what tegra is doing. We can leave the legacy, unconverted boards where they are (mach-kirkwood/guruplug-setup.c), but what about the common code they depend on (mpp.c, pcie.c, etc)? That's what I was suggesting putting in mach-mvebu/board/... Of course, we could leave everything alone (keep plat-orion/ as is), and create mach-mvebu/ for all devicetree boards under the mvebu umbrella. As boards are converted/moved to mach-mvebu/, they are deleted from their original mach-*/ All new boards would also go into mach-mvebu/ thx, Jason.