public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: jrnieder@gmail.com (Jonathan Nieder)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ixp4xx: fix compilation by adding gpiolib support
Date: Wed, 23 May 2012 12:27:03 -0500	[thread overview]
Message-ID: <20120523172703.GI21608@burratino> (raw)
In-Reply-To: <1337789991-5283-1-git-send-email-richardcochran@gmail.com>

Hi Richard,

Richard Cochran wrote:

> Once again, ixp4xx no longer even compiles.

Awesome, thanks for your persistence.

>From [1] I see some details that would be useful for the commit message.
Could you include them?

	This patch adds gpiolib support for the IXP4xx platform, which fixes the
	compilation of several ixp4xx platforms, e.g.:

	In file included from arch/arm/mach-ixp4xx/include/mach/gpio.h:72,
			     from /home/frogger/projects/server/linux/arch/arm/include/asm/gpio.h:9,
			     from include/linux/gpio.h:30,
			     from arch/arm/mach-ixp4xx/nslu2-setup.c:19:
	include/asm-generic/gpio.h: In function 'gpio_get_value_cansleep':
	include/asm-generic/gpio.h:218: error: implicit declaration of function '__gpio_get_value'
	include/asm-generic/gpio.h: In function 'gpio_set_value_cansleep':
	include/asm-generic/gpio.h:224: error: implicit declaration of function '__gpio_set_value'

And:

	The problem was introduced with commit eb9ae7f2a381 ("gpio: fix build
	error in include/asm-generic/gpio.h").

[...]
> This fix should also go for 3.1, 3.2, 3.3, and 3.4.

If 3.1.y were still maintained, do I understand correctly that it
would not need this because it lacks eb9ae7f2a381?

[...]
>  arch/arm/Kconfig                         |    2 +-
>  arch/arm/mach-ixp4xx/common.c            |   48 +++++++++++++++++-
>  arch/arm/mach-ixp4xx/include/mach/gpio.h |   79 +-----------------------------
>  3 files changed, 48 insertions(+), 81 deletions(-)

This is bigger than the usual stable-kernel-rules.txt standard (100
lines with context), but the gpio.h change leaves me so happy that I
suspect it should be okay. :)  If it isn't, we can cross that bridge
later.

Hope that helps,
Jonathan

[1] http://thread.gmane.org/gmane.linux.kernel/1250585/focus=1250584

  reply	other threads:[~2012-05-23 17:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 16:19 [PATCH] ixp4xx: fix compilation by adding gpiolib support Richard Cochran
2012-05-23 17:27 ` Jonathan Nieder [this message]
2012-05-23 18:18   ` Jonathan Nieder
2012-05-24  7:10     ` Richard Cochran
2012-05-23 17:43 ` Arnd Bergmann
2012-05-23 19:07   ` Arnaud Patard (Rtp)
2012-05-23 19:39     ` Arnd Bergmann
2012-05-24  7:07       ` Richard Cochran
2012-05-24  9:01         ` Arnd Bergmann
2012-05-24 10:16           ` Richard Cochran
2012-05-24  9:31       ` Imre Kaloz
2012-05-24 13:12         ` Arnd Bergmann
2012-05-24 15:13           ` Richard Cochran
2012-05-27 20:52     ` Krzysztof Halasa
2012-05-28  5:43       ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120523172703.GI21608@burratino \
    --to=jrnieder@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox