[PATCH] Fix OMAP4 boot regression

[PATCH] Fix OMAP4 boot regression

[Russell King - ARM Linux]

Fix a boot regression in existing kernels causing:

genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq XXX

caused by 1c6c6952 (genirq: Reject bogus threaded irq requests).

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
--
 drivers/mmc/host/omap_hsmmc.c |    2 +-
 drivers/rtc/rtc-twl.c         |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index d76fc82..84016cb 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1962,7 +1962,7 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev)
 		ret = request_threaded_irq(mmc_slot(host).card_detect_irq,
 					   NULL,
 					   omap_hsmmc_detect,
-					   IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
+					   IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 					   mmc_hostname(mmc), host);
 		if (ret) {
 			dev_dbg(mmc_dev(host->mmc),
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index 258abea..c5d06fe 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -510,7 +510,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
 	}
 
 	ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
-				   IRQF_TRIGGER_RISING,
+				   IRQF_TRIGGER_RISING | IRQF_ONESHOT,
 				   dev_name(&rtc->dev), rtc);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "IRQ is not free.\n");

[PATCH] Fix OMAP4 boot regression

[S, Venkatraman]

On Thu, May 24, 2012 at 2:34 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> Fix a boot regression in existing kernels causing:
>
> genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq XXX
>
> caused by 1c6c6952 (genirq: Reject bogus threaded irq requests).
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> --
> ?drivers/mmc/host/omap_hsmmc.c | ? ?2 +-

Thanks Russell.
The omap_hsmmc part of the change was already posted [1] and queued up
in mmc-next.

Regards,
Venkat.

[1] http://www.spinics.net/lists/linux-omap/msg70496.html

> ?drivers/rtc/rtc-twl.c ? ? ? ? | ? ?2 +-
> ?2 files changed, 2 insertions(+), 2 deletions(-)
>