From: rubini@gnudd.com (Alessandro Rubini)
To: linux-arm-kernel@lists.infradead.org
Subject: amba, tegra-ahb and pci (Kconfig question)
Date: Mon, 28 May 2012 10:17:37 +0200 [thread overview]
Message-ID: <20120528081737.GA8031@mail.gnudd.com> (raw)
Hello.
I plan to submit drivers/amba/apb-pci.c (and later ahb-pci.c), because
the amba-pl011-pci.c I proposed is actually a generic bridge and there
are several such devices in my chip.
I planned to use obj-$(CONFIG_PCI) in drivers/amba/Makefile, but
commit 87d0bab2cba3c31624b80cc68bcf5e29ef969458 had this in drivers/Makefile:
-obj-$(CONFIG_ARM_AMBA) += amba/
+obj-y += amba/
So I ask how to proceed. Shall I define CONFIG_PCI_AMBA or something
like that, or should drivers/amba/tegra-ahb.c be moved to
arch/arm/mach-tegra ? (I prefer the latter and can submit such patch,
but not without authorization from the involved parties).
If the former (CONFIG_PCI_AMBA), where should the symbol be defined?
My personal preference is doing it like this, plus help message:
config PCI_AMBA
bool "PCI-to-AMBA bridge"
depends on ARM_AMBA && PCI
In this case, shall I name CONFIG_STA2X11 in the depends, or in the
help message, or I'd better be generic, knowing someone else will soon
have similar things?
Thanks
/alessandro
next reply other threads:[~2012-05-28 8:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 8:17 Alessandro Rubini [this message]
2012-05-28 8:24 ` amba, tegra-ahb and pci (Kconfig question) Russell King - ARM Linux
2012-05-28 8:34 ` Alessandro Rubini
2012-05-28 10:23 ` Ben Dooks
2012-05-28 10:33 ` Russell King - ARM Linux
2012-05-29 2:34 ` Stephen Warren
2012-05-29 6:31 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120528081737.GA8031@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).