From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MXS: Add DENX M28 dts file
Date: Mon, 28 May 2012 18:30:23 +0200 [thread overview]
Message-ID: <201205281830.23380.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5C-XbGqWHxpX24V6X58rcnSeSobuyJNiZTJErQi55tEbQ@mail.gmail.com>
Dear Fabio Estevam,
> Hi Marek,
>
> On Sat, May 26, 2012 at 11:12 PM, Marek Vasut <marex@denx.de> wrote:
> > + sound {
> > + compatible = "fsl,imx28-evk-sgtl5000",
> > + "fsl,mxs-audio-sgtl5000";
> > + model = "imx28-evk-sgtl5000";
> > + saif-controllers = <&saif0 &saif1>;
> > + audio-codec = <&sgtl5000>;
> > + };
> > +};
>
> Shouldn't this be:
>
> sound {
> compatible = "fsl,imx28-m28-sgtl5000",
> "fsl,mxs-audio-sgtl5000";
Wait, no ... it should not, why should it? (I'm still very lame with this device
tree stuff, so any advice is very welcome)
> model = "imx28-m28-sgtl5000";
> saif-controllers = <&saif0 &saif1>;
> audio-codec = <&sgtl5000>;
> };
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-28 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 2:12 [PATCH] MXS: Add DENX M28 dts file Marek Vasut
2012-05-28 15:27 ` Fabio Estevam
2012-05-28 16:28 ` Marek Vasut
2012-05-28 16:30 ` Marek Vasut [this message]
2012-05-29 12:57 ` Fabio Estevam
2012-06-06 5:54 ` Shawn Guo
2012-06-06 8:17 ` Shawn Guo
2012-06-08 18:32 ` Marek Vasut
2012-06-11 5:40 ` Shawn Guo
2012-06-08 19:03 ` Marek Vasut
2012-06-11 5:45 ` Shawn Guo
2012-06-11 5:56 ` Huang Shijie
2012-06-11 10:59 ` Marek Vasut
2012-06-12 6:17 ` Huang Shijie
2012-06-12 11:09 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205281830.23380.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).