From mboxrd@z Thu Jan  1 00:00:00 1970
From: marex@denx.de (Marek Vasut)
Date: Mon, 28 May 2012 18:30:23 +0200
Subject: [PATCH] MXS: Add DENX M28 dts file
In-Reply-To: <CAOMZO5C-XbGqWHxpX24V6X58rcnSeSobuyJNiZTJErQi55tEbQ@mail.gmail.com>
References: <1338084735-12083-1-git-send-email-marex@denx.de>
 <CAOMZO5C-XbGqWHxpX24V6X58rcnSeSobuyJNiZTJErQi55tEbQ@mail.gmail.com>
Message-ID: <201205281830.23380.marex@denx.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Dear Fabio Estevam,

> Hi Marek,
> 
> On Sat, May 26, 2012 at 11:12 PM, Marek Vasut <marex@denx.de> wrote:
> > +       sound {
> > +               compatible = "fsl,imx28-evk-sgtl5000",
> > +                            "fsl,mxs-audio-sgtl5000";
> > +               model = "imx28-evk-sgtl5000";
> > +               saif-controllers = <&saif0 &saif1>;
> > +               audio-codec = <&sgtl5000>;
> > +       };
> > +};
> 
> Shouldn't this be:
> 
> sound {
> 	compatible = "fsl,imx28-m28-sgtl5000",
> 		     "fsl,mxs-audio-sgtl5000";

Wait, no ... it should not, why should it? (I'm still very lame with this device 
tree stuff, so any advice is very welcome)

> 	model = "imx28-m28-sgtl5000";
> 	saif-controllers = <&saif0 &saif1>;
> 	audio-codec = <&sgtl5000>;
> };

Best regards,
Marek Vasut