From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial/of-serial: Add 16654 chip to compatible string list
Date: Mon, 28 May 2012 19:39:13 +0100 [thread overview]
Message-ID: <20120528183913.GD28290@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4FC3C156.5040609@antcom.de>
On Mon, May 28, 2012 at 08:17:58PM +0200, Roland Stigge wrote:
> On 28/05/12 20:01, Russell King - ARM Linux wrote:
> >> Now, introducing a new type, can I add to 8250.c's uart_config[] by
> >> introducing a new type (no. 22) after PORT_XR17D15X? Unfortunately,
> >> there are the "ARM specific type numbers" after current PORT_MAX_8250
> >> (21), but those are not listed in 8250.c's uart_config[]. Or how am I
> >> supposed to add a new type?
> >
> > If it's 8250, stick it in with the group, otherwise the array will
> > become stupidly large. That's why there's a separation of the two.
>
> Do you mean adding one element to uart_config[] and increasing
> PORT_MAX_8250 (actually, the size of uart_config[]) by one? I would also
> need to increase the indices of all the following "ARM specific type
> numbers" by one (the second group).
#define PORT_XR17D15X 21 /* Exar XR17D15x UART */
#define PORT_MAX_8250 21 /* max port ID */
#define PORT_PXA 31
There's space between 21 and 31...
prev parent reply other threads:[~2012-05-28 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 9:58 [PATCH] serial/of-serial: Add 16654 chip to compatible string list Roland Stigge
2012-05-28 10:03 ` Russell King - ARM Linux
2012-05-28 11:20 ` Roland Stigge
2012-05-28 15:03 ` Russell King - ARM Linux
2012-05-28 16:27 ` Roland Stigge
2012-05-28 16:31 ` Russell King - ARM Linux
2012-05-28 17:48 ` Roland Stigge
2012-05-28 18:01 ` Russell King - ARM Linux
2012-05-28 18:17 ` Roland Stigge
2012-05-28 18:39 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120528183913.GD28290@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).