From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: omap: Fix broken reg_shift initialization
Date: Wed, 30 May 2012 00:13:01 -0700 [thread overview]
Message-ID: <20120530071300.GH12766@atomide.com> (raw)
In-Reply-To: <20120529130312.GE12766@atomide.com>
Commit fa550189 (mmc: core: Prevent eMMC VCC supply to be cut from late init)
slightly affected timings for how things are done for the omap MMC driver
causing the MMC cards not getting detected any longer.
Turns out this was caused by buggy reg_shift initialization in the omap
MMC driver that was happening after mmc_add_host() was being called.
Fix this by initializing reg_shift before mmc_add_host() is called.
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
Heh found it! Chris, maybe Cc stable on this one?
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1485,6 +1485,7 @@ static int __devinit mmc_omap_probe(struct platform_device *pdev)
}
host->nr_slots = pdata->nr_slots;
+ host->reg_shift = (cpu_is_omap7xx() ? 1 : 2);
host->mmc_omap_wq = alloc_workqueue("mmc_omap", 0, 0);
if (!host->mmc_omap_wq)
@@ -1500,8 +1501,6 @@ static int __devinit mmc_omap_probe(struct platform_device *pdev)
}
}
- host->reg_shift = (cpu_is_omap7xx() ? 1 : 2);
-
return 0;
err_destroy_wq:
next prev parent reply other threads:[~2012-05-30 7:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 13:21 Regression for non-eMMC cards with commit fa550189? Tony Lindgren
2012-05-29 6:52 ` Ulf Hansson
2012-05-29 7:40 ` Felipe Balbi
2012-05-29 12:47 ` Tony Lindgren
2012-05-29 12:50 ` Felipe Balbi
2012-05-29 13:03 ` Tony Lindgren
2012-05-30 7:13 ` Tony Lindgren [this message]
2012-06-06 13:48 ` [PATCH] mmc: omap: Fix broken reg_shift initialization Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120530071300.GH12766@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).