From: michael@walle.cc (Michael Walle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi-orion: remove uneeded spi_info
Date: Sun, 3 Jun 2012 23:51:22 +0200 [thread overview]
Message-ID: <201206032351.22925.michael@walle.cc> (raw)
In-Reply-To: <20120603210424.GM14756@titan.lakedaemon.net>
Hi Jason,
Am Sonntag 03 Juni 2012, 23:04:24 schrieb Jason Cooper:
> On Sun, Jun 03, 2012 at 10:10:14PM +0200, Michael Walle wrote:
> > This was formerly used to store the tclk value. Remove it.
> >
> > Signed-off-by: Michael Walle <michael@walle.cc>
> > ---
> >
> > drivers/spi/spi-orion.c | 5 -----
> > 1 files changed, 0 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
> > index dfd04e9..2760450 100644
> > --- a/drivers/spi/spi-orion.c
> > +++ b/drivers/spi/spi-orion.c
> > @@ -45,7 +45,6 @@ struct orion_spi {
> >
> > void __iomem *base;
> > unsigned int max_speed;
> > unsigned int min_speed;
> >
> > - struct orion_spi_info *spi_info;
> >
> > struct clk *clk;
> >
> > };
> >
> > @@ -450,12 +449,9 @@ static int __init orion_spi_probe(struct
> > platform_device *pdev)
> >
> > struct spi_master *master;
> > struct orion_spi *spi;
> > struct resource *r;
> >
> > - struct orion_spi_info *spi_info;
> >
> > unsigned long tclk_hz;
> > int status = 0;
> >
> > - spi_info = pdev->dev.platform_data;
> > -
> >
> > master = spi_alloc_master(&pdev->dev, sizeof *spi);
> > if (master == NULL) {
> >
> > dev_dbg(&pdev->dev, "master allocation failed\n");
> >
> > @@ -476,7 +472,6 @@ static int __init orion_spi_probe(struct
> > platform_device *pdev)
> >
> > spi = spi_master_get_devdata(master);
> > spi->master = master;
> >
> > - spi->spi_info = spi_info;
> >
> > spi->clk = clk_get(&pdev->dev, NULL);
>
> It's not relevant to this patch, but later in the patch series, you
> initialize this device via devicetree. Did you add the clock node? Is
> there a dependency for this series that I missed?
i added the original device name by using the auxdata in
of_platform_populate(). See "[PATCH 2/3] ARM: kirkwood: use devicetree for
orion-spi"
--
Michael
prev parent reply other threads:[~2012-06-03 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 20:10 [PATCH] spi-orion: remove uneeded spi_info Michael Walle
2012-06-03 20:54 ` Jason Cooper
2012-06-03 21:04 ` Jason Cooper
2012-06-03 21:51 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206032351.22925.michael@walle.cc \
--to=michael@walle.cc \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox