linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup
Date: Tue, 5 Jun 2012 04:08:19 -0700	[thread overview]
Message-ID: <20120605110818.GN12766@atomide.com> (raw)
In-Reply-To: <87likize4t.fsf@ti.com>

* Kevin Hilman <khilman@ti.com> [120523 16:15]:
> "Govindraj.R" <govindraj.raja@ti.com> writes:
> 
> > From: "Govindraj.R" <govindraj.raja@ti.com>
> >
> > The commit (bce492c0  ARM: OMAP2+: UART: Fix incorrect population of
> > default uart pads) removed default uart pads that where getting populated
> > and which was making rx pin wakeup capable. If uart pads were used in
> > different mode by any other module then it would fail since the default
> > pads took over all the uart pins forcefully. With removal of default pads
> > the rx_pad wakeup for console uart while waking up from off mode is broken.
> >
> > Utilise the mux api available to probe the availability of mux pins
> > in uart mode and probe for availability of uart pin in mux mode0
> > if uart is available as uart pin itself then configure rx pin
> > as wakeup capable.
> >
> > This patch itself doesn't cater to all boards. Boards using uart rx wakeup
> > mechanism should ensure the usage of omap_serial_init_port by configuring
> > required uart ports and pass necessary mux data, till then this probing of
> > uart pins can cater to enabling of rx pad wakeup to most of the boards.
> >
> > This patch can also throw some boot warning from _omap_mux_get_by_name
> > if pin is requested for availability is not present while dynamically probing
> > the uart pins availability such boot warnings can be addressed only when board
> > files are patched with omap_serial_init_port calls passing the right pads
> > needed for a given port.
> >
> > Discussion Threads for reference:
> > http://www.spinics.net/lists/linux-omap/msg69859.html
> > http://www.spinics.net/lists/linux-omap/msg68659.html
> >
> > Cc: Felipe Balbi <balbi@ti.com>
> > Cc: Kevin Hilman <khilman@ti.com>
> > Cc: Russ Dill <russ.dill@gmail.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Ameya Palande <ameya.palande@ti.com>
> > Signed-off-by: Govindraj.R <govindraj.raja@ti.com>
> 
> Tony, it's up to you if you're OK with this mux interface, but I can at
> least confirm that this gets runtime PM + UART wakeups working again on
> the boards I tried: 3530/Overo, 3430/n900, 3530/OMAP3EVM.

OK good to hear. Patch looks good to me, applying into fixes branch.

Regards,

Tony

  reply	other threads:[~2012-06-05 11:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 13:05 [PATCH v2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup Govindraj.R
2012-05-10 19:11 ` Tony Lindgren
2012-05-11  9:13   ` Raja, Govindraj
2012-05-11  8:34 ` Russ Dill
2012-05-11  9:15   ` Raja, Govindraj
2012-05-11  9:40 ` [PATCH v3] " Govindraj.R
2012-05-23 23:11   ` Kevin Hilman
2012-06-05 11:08     ` Tony Lindgren [this message]
2012-06-05 11:28   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120605110818.GN12766@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).