linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] pinctrl: add samsung pinctrl and gpiolib driver
Date: Fri, 8 Jun 2012 05:32:13 -0700	[thread overview]
Message-ID: <20120608123213.GP12766@atomide.com> (raw)
In-Reply-To: <CACRpkdZDnFW4-bDsHN5BOr2e5NLGzouSBY7ngf-VsoPn-SyxAA@mail.gmail.com>

* Linus Walleij <linus.walleij@linaro.org> [120531 18:40]:
> On Thu, May 24, 2012 at 7:47 AM, Thomas Abraham
> <thomas.abraham@linaro.org> wrote:
> 
> > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> 
> It would be nice if some DT person could review the bindings, but if
> nothing happens
> I will accept them as-is.

Looks OK to me, that's a bit slower way of parsing pins compared to
just register value pairs but allows naming them. And it was agreed
that it's up to the driver to define it's binding.
 
> This driver is special since it seems to keep all pin, group and
> function information
> in the device tree, but not like Tony is doing it in pinctrl-simple,
> if I understand
> correctly?

Looks like it's using static arrays which I was too using earlier.
That too should be OK for now, then at some point we can probably
have something generic to manage the pins for at least some drivers.

Regards,

Tony
 

  parent reply	other threads:[~2012-06-08 12:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 23:47 [PATCH 0/3] pinctrl: add support for samsung pinctrl driver Thomas Abraham
2012-05-23 23:47 ` [PATCH 1/3] pinctrl: add samsung pinctrl and gpiolib driver Thomas Abraham
2012-06-01  1:36   ` Linus Walleij
2012-06-01  1:58     ` Thomas Abraham
2012-06-08 12:32     ` Tony Lindgren [this message]
2012-05-23 23:47 ` [PATCH 2/3] pinctrl: add exynos4210 specific driver data for samsung pinctrl driver Thomas Abraham
2012-06-01  1:37   ` Linus Walleij
2012-05-23 23:47 ` [PATCH 3/3] gpio: exynos4: skip gpiolib registration if pinctrl driver is used Thomas Abraham
2012-05-26  0:44   ` Grant Likely
2012-06-05 12:46   ` Linus Walleij
2012-06-01  1:40 ` [PATCH 0/3] pinctrl: add support for samsung pinctrl driver Linus Walleij
2012-06-01  2:06   ` Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120608123213.GP12766@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).