From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Kirkwood: Fix crash when neither NAND nor SPI
Date: Fri, 8 Jun 2012 15:34:13 +0000 [thread overview]
Message-ID: <201206081534.13261.arnd@arndb.de> (raw)
In-Reply-To: <1339164583-11596-1-git-send-email-andrew@lunn.ch>
On Friday 08 June 2012, Andrew Lunn wrote:
> Both NAND and SPI make use of the RUNIT clk. However, if neither NAND
> nor SPI is used in the system, RUNIT clock gets turned off, and the
> SoC hard locks. It appears something else in the SoC, which is not
> documented, is also using RUNIT. So prepare and enable RUNIT clock in
> kirkwood_clk_init().
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
This looks bogus, because if you really need to enable that clock all
the time, we don't even need a way to turn it off.
Do you need a similar change with the 3.4 kernel before the big
change to the clock framework? If not, I would guess that there
is some other problem.
Arnd
next prev parent reply other threads:[~2012-06-08 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 14:09 [PATCH] ARM: Kirkwood: Fix crash when neither NAND nor SPI Andrew Lunn
2012-06-08 15:34 ` Arnd Bergmann [this message]
2012-06-08 16:42 ` Andrew Lunn
2012-06-08 17:42 ` Jon Medhurst (Tixy)
2012-06-08 18:43 ` Andrew Lunn
2012-06-10 18:09 ` Simon Baatz
2012-06-10 20:13 ` Andrew Lunn
2012-06-10 20:33 ` Simon Baatz
2012-06-11 12:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206081534.13261.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).