linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Kirkwood: Fix crash when neither NAND nor SPI
Date: Fri, 8 Jun 2012 20:43:17 +0200	[thread overview]
Message-ID: <20120608184317.GD674@lunn.ch> (raw)
In-Reply-To: <1339177361.9569.23.camel@linaro1.home>

> > However, all current systems have either SPI FLASH or NAND, since that
> > is how these devices boot. So, under normal conditions, this clock is
> > always used, and so never gets turned off as being unused.
> 
> What if your filesystems are on devices other than flash (I use an SD
> card on my Sheevaplugs). In that case flash isn't used at all by the
> Linux kernel and could be safely turned off. I'm not saying that this is
> worth the hassle, just pointing out that flash may be unused by Linux on
> some systems.

The current sheevaplug code sets up the nand driver and mtd
partitions. That is sufficient to ensure the clock is kept on. It does
not matter if a partitions are used or not.

I in fact use a similar system to you. I typically use kirkwood
devices which are NAS boxes and i have the root file system on the
disk and i tftpboot the kernel. The SPI flash is unused, but its still
made available via mtd.

Problems will however come when somebody creates a box which really
does boot from disk and skips NAND and SPI-FLASH in the DT description
of the device. That is why i like claiming this clock in the core
code, just to say there is something in the CPU core using it. 

     Andrew

  reply	other threads:[~2012-06-08 18:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 14:09 [PATCH] ARM: Kirkwood: Fix crash when neither NAND nor SPI Andrew Lunn
2012-06-08 15:34 ` Arnd Bergmann
2012-06-08 16:42   ` Andrew Lunn
2012-06-08 17:42     ` Jon Medhurst (Tixy)
2012-06-08 18:43       ` Andrew Lunn [this message]
2012-06-10 18:09 ` Simon Baatz
2012-06-10 20:13   ` Andrew Lunn
2012-06-10 20:33     ` Simon Baatz
2012-06-11 12:17   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120608184317.GD674@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).