From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: RFC: changing DMA slave configuration API
Date: Mon, 11 Jun 2012 09:24:24 +0100 [thread overview]
Message-ID: <20120611082424.GE11404@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1339390249.1927.1623.camel@vkoul-udesk3>
On Mon, Jun 11, 2012 at 10:20:49AM +0530, Vinod Koul wrote:
> I think it is a good idea. And I would like to extend it even a little
> bit. Do we have any users of peripheral to peripheral slave dma?
> IIRC that is not the case, or does anyone know of existence or plans
> for such a h/w?
>
> If not, lets junk the src/dst fields and keep burst, length, addr fields
> which point to the peripheral values.
>
> Alternatively if we need both, then we can't have union and Russell's
> idea seems good one :)
We don't need the union whatever way that goes.
The question over whether we have the src/dst fields is whether we want
to support a different configuration for DMA_DEV_TO_MEM/DMA_MEM_TO_DEV
without having to reconfigure the channel each time its direction is
switched.
Out of the following users:
drivers/mmc/host/mmci.c
drivers/spi/spi-pl022.c
drivers/tty/serial/amba-pl011.c
with amba-pl08x, I don't see any which set a different configuration
depending on direction, and sa11x0 and OMAP DMA engine drivers only
support one direction per channel.
So, the question really comes down to whether we _want_ to support this,
and how painful it would be to re-introduce this if we did need it.
Maybe the right answer is to use the control command value to sort that
out when we come to it.
next prev parent reply other threads:[~2012-06-11 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 10:20 RFC: changing DMA slave configuration API Russell King - ARM Linux
2012-06-10 11:19 ` Barry Song
2012-06-10 11:22 ` Russell King - ARM Linux
2012-06-11 4:50 ` Vinod Koul
2012-06-11 8:24 ` Russell King - ARM Linux [this message]
2012-06-12 6:04 ` Vinod Koul
2012-06-11 9:33 ` Dong Aisheng
2012-06-12 5:54 ` Vinod Koul
2012-06-11 20:36 ` David Brown
2012-08-14 10:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611082424.GE11404@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).