From: mturquette@ti.com (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] clk: add ICST307 driver
Date: Tue, 12 Jun 2012 16:06:30 -0700 [thread overview]
Message-ID: <20120612230630.GK19410@gmail.com> (raw)
In-Reply-To: <1339429196-32584-1-git-send-email-linus.walleij@linaro.org>
On 20120611-17:39, Linus Walleij wrote:
> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> index b9a5158..a7a7cf8 100644
> --- a/drivers/clk/Makefile
> +++ b/drivers/clk/Makefile
> @@ -5,3 +5,4 @@ obj-$(CONFIG_COMMON_CLK) += clk.o clk-fixed-rate.o clk-gate.o \
> # SoCs specific
> obj-$(CONFIG_ARCH_MXS) += mxs/
> obj-$(CONFIG_PLAT_SPEAR) += spear/
> +obj-$(CONFIG_CLK_ICST) += clk-icst.o
Is there a better place to put this than the top-level directory?
> +struct clk * __init icst_clk_init(struct device *dev, const struct clk_icst_desc *desc)
Nitpick: icst_clk_init should be renamed icst_clk_register to more
closely resemble other clock registration functions which allocate
memory dynamically.
So far the "_init" suffix has been used by functions which operate on
statically initialized data.
Regards,
Mike
next prev parent reply other threads:[~2012-06-12 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 15:39 [PATCH 2/3] clk: add ICST307 driver Linus Walleij
2012-06-12 23:06 ` Mike Turquette [this message]
2012-06-13 8:38 ` Linus Walleij
2012-06-13 14:42 ` Turquette, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612230630.GK19410@gmail.com \
--to=mturquette@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).