linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: apw@canonical.com (Andy Whitcroft)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 1/4] ARM: topology: Add arch_scale_freq_power function
Date: Wed, 13 Jun 2012 20:27:40 +0100	[thread overview]
Message-ID: <20120613192740.GZ5878@dm> (raw)
In-Reply-To: <1339591969.8980.30.camel@twins>

On Wed, Jun 13, 2012 at 02:52:49PM +0200, Peter Zijlstra wrote:
> On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote:
> >         }
> >         smp_wmb();
> >  } 
> 
> You know what.. we should make checkpatch report an error for memory
> barriers that don't have a comment. 
> 
> I know this isn't added by this patch, but every time I see something
> like it I cry a little.

Actually if it was a new line, it would have been reported, at least in
theory:

    # check for memory barriers without a comment.
		    if ($line =~
    /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/)
    {
	if (!ctx_has_comment($first_line, $linenr)) {
	    CHK("MEMORY_BARRIER",
		"memory barrier without comment\n" . $herecurr);
	}
    }

-apw

  reply	other threads:[~2012-06-13 19:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12 12:02 [RFC 0/4] ARM: topology: set the capacity of each cores for big.LITTLE Vincent Guittot
2012-06-12 12:02 ` [RFC 1/4] ARM: topology: Add arch_scale_freq_power function Vincent Guittot
2012-06-13  8:50   ` Jean Pihet
2012-06-13  9:22     ` Vincent Guittot
2012-06-13 12:52   ` Peter Zijlstra
2012-06-13 19:27     ` Andy Whitcroft [this message]
2012-06-13 19:30       ` Joe Perches
2012-06-13 21:51       ` Peter Zijlstra
2012-06-12 12:02 ` [RFC 2/4] ARM: topology: factorize the update of sibling masks Vincent Guittot
2012-06-13 12:54   ` Peter Zijlstra
2012-06-12 12:02 ` [RFC 3/4] ARM: topology: Update cpu_power according to DT information Vincent Guittot
2012-06-13  8:59   ` Jean Pihet
2012-06-13  9:44     ` Vincent Guittot
2012-06-13 12:44       ` Amit Kucheria
2012-06-13 12:47         ` Peter Zijlstra
2012-06-13 12:50           ` Jean Pihet
2012-06-13 13:29           ` Vincent Guittot
2012-06-13 13:32             ` Peter Zijlstra
2012-06-13 14:31               ` Vincent Guittot
2012-06-13 13:07   ` Peter Zijlstra
2012-06-13 14:54     ` Vincent Guittot
2012-06-13 16:06       ` Peter Zijlstra
2012-06-13 13:09   ` Peter Zijlstra
2012-06-13 14:42     ` Nicolas Pitre
2012-06-13 13:19   ` Peter Zijlstra
2012-06-12 12:02 ` [RFC 4/4] sched: cpu_power: enable ARCH_POWER Vincent Guittot
2012-06-13 12:50   ` Peter Zijlstra
2012-06-13 13:20     ` Vincent Guittot
2012-06-13 13:28       ` Peter Zijlstra
2012-06-13 13:50         ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120613192740.GZ5878@dm \
    --to=apw@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).