From mboxrd@z Thu Jan 1 00:00:00 1970 From: aisheng.dong@freescale.com (Dong Aisheng) Date: Thu, 14 Jun 2012 16:04:55 +0800 Subject: [PATCH 01/16] ARM: imx: eliminate macro IMX_GPIO_TO_IRQ() In-Reply-To: <20120614073956.GD31565@S2101-09.ap.freescale.net> References: <1339653587-4832-1-git-send-email-shawn.guo@linaro.org> <1339653587-4832-2-git-send-email-shawn.guo@linaro.org> <20120614073145.GB2086@shlinux2.ap.freescale.net> <20120614073956.GD31565@S2101-09.ap.freescale.net> Message-ID: <20120614080454.GD2086@shlinux2.ap.freescale.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 14, 2012 at 03:39:58PM +0800, Shawn Guo wrote: > On Thu, Jun 14, 2012 at 03:31:46PM +0800, Dong Aisheng wrote: > > > - .irq = IMX_GPIO_TO_IRQ(TSC2007_IRQGPIO), > > > + /* irq number is run-time assigned */ > > Maybe this line is not need. > > > Documentation never harms. > Hmm, you may see in the patch, this comment is added in every places where need change even in the same file, so totally we added a lot duplicated lines. IMHO for this common sense bits, we may not have to document it. User can refer to common document or code. Regards Dong Aisheng