From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] lib/decompress_unxz.c: removing all memory helper functions
Date: Thu, 14 Jun 2012 19:23:50 +0100 [thread overview]
Message-ID: <20120614182350.GB7628@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4FD6B472.7040609@zytor.com>
On Mon, Jun 11, 2012 at 08:16:02PM -0700, H. Peter Anvin wrote:
> On 06/11/2012 08:05 PM, T Makphaibulchoke wrote:
> > Cleaning up the file lib/decompress_unxz.c, moving all memory helper functions,
> > e.g. memmove, to a new common source file, lib/boot/mem.c.
> >
> > In additon to including the decompressor, any architecture supporting the XZ
> > decompression needs to also include this new source file.
> >
> > Also moving some other duplicated memory helper functions to this new source
> > file from the arm, s390, sh and x86 preboot environments. All 4 architectures
> > build without error when using any compression.
> >
> > Adding a new file lib/boot/mem.c, containing memory helper functions required
> > by different compression types.
> >
> > Adding memcmp declaration workaround and removing the memmove and memcpy
> > defines workaround from arch/arm/boot/compressed/decompress.c
> >
> > Removing the common functions, memmove, memcmp and memset, and adding the new
> > source file include to arch/arm/boot/compressed/string.c.
> >
> > Removing the memcpy and memmove functions and adding the new source file
> > include to arch/s390/boot/compressed/misc.c.
> >
> > Removing the memset function and adding the new source file include to
> > arch/sh/boot/compressed/misc.c
> >
> > Removing the memset function from arch/x86/boot/compressed/misc.c and move
> > the memcpy function to the file arch/x86/boot/compressed/string.c
> >
> > Adding the memcpy function and the new source file include to
> > arch/x86/boot/compressed/string.c
> >
>
> I can take this if Russell, Martin or Heiko, and Paul are willing to ack it.
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
(Tested on OMAP4430SDP).
next prev parent reply other threads:[~2012-06-14 18:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 3:05 [PATCH v2] lib/decompress_unxz.c: removing all memory helper functions T Makphaibulchoke
2012-06-12 3:16 ` H. Peter Anvin
2012-06-12 14:35 ` Russell King - ARM Linux
2012-06-14 13:47 ` Russell King - ARM Linux
2012-06-14 14:35 ` H. Peter Anvin
2012-06-14 15:44 ` Russell King - ARM Linux
2012-06-14 16:15 ` H. Peter Anvin
2012-06-13 9:32 ` Martin Schwidefsky
2012-06-14 18:23 ` Russell King - ARM Linux [this message]
2012-06-12 3:27 ` Paul Mundt
2012-06-12 16:18 ` Lasse Collin
2012-06-12 17:26 ` Nicolas Pitre
2012-06-12 17:30 ` H. Peter Anvin
2012-06-12 17:40 ` Joe Perches
2012-06-12 19:45 ` Thavatchai Makphaibulcboke
2012-06-12 17:44 ` Nicolas Pitre
2012-06-12 17:48 ` H. Peter Anvin
2012-06-12 17:49 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614182350.GB7628@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).