From mboxrd@z Thu Jan  1 00:00:00 1970
From: aisheng.dong@freescale.com (Dong Aisheng)
Date: Mon, 18 Jun 2012 16:19:44 +0800
Subject: [PATCH 07/16] dma: ipu: remove the use of ipu_platform_data
In-Reply-To: <20120616030106.GD29663@S2101-09.ap.freescale.net>
References: <1339653587-4832-1-git-send-email-shawn.guo@linaro.org>
 <1339653587-4832-8-git-send-email-shawn.guo@linaro.org>
 <20120615093713.GE8383@shlinux2.ap.freescale.net>
 <20120616030106.GD29663@S2101-09.ap.freescale.net>
Message-ID: <20120618081943.GA25447@shlinux2.ap.freescale.net>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Sat, Jun 16, 2012 at 11:01:08AM +0800, Shawn Guo wrote:
> On Fri, Jun 15, 2012 at 05:37:14PM +0800, Dong Aisheng wrote:
> > On Thu, Jun 14, 2012 at 01:59:38PM +0800, Shawn Guo wrote:
> > .......
> > > @@ -354,10 +355,12 @@ static struct irq_chip ipu_irq_chip = {
> > >  /* Install the IRQ handler */
> > >  int __init ipu_irq_attach_irq(struct ipu *ipu, struct platform_device *dev)
> > >  {
> > > -	struct ipu_platform_data *pdata = dev->dev.platform_data;
> > > -	unsigned int irq, irq_base, i;
> > > +	unsigned int irq, i;
> > > +	int irq_base = irq_alloc_descs(-1, 0, CONFIG_MX3_IPU_IRQS,
> > > +				       numa_node_id());
> > >  
> > > -	irq_base = pdata->irq_base;
> > > +	if (irq_base < 0)
> > > +		return irq_base;
> > >  
> > Need not add irqdomain for this irq range?
> > Can we still service this irq properly without irqdomain mapping?
> > 
> Yes, I think it should still work, because the driver has the mapping
> management on its own,  though someday we need to replace its own
> mapping with irqdomain anyway when we move the driver to device tree.
> 
Hmm, i'm wondering it may not make too much sense to alloc_descs without
using irqdomain since the allocated irqs are all virtual irqs.
Using private mapping is not recommended.
Maybe we can do it together with this patch since irqdomain support
does not depend on device tree.
What do you think?

Regards
Dong Aisheng