linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/mxc: use the edge_sel feature if available
Date: Wed, 20 Jun 2012 11:21:57 +0200	[thread overview]
Message-ID: <20120620092157.GR28394@pengutronix.de> (raw)
In-Reply-To: <CACRpkdbLMCirzyk-UbS0zx_TpY-mx51-aEn0bk-48eGMhmm=fg@mail.gmail.com>

On Wed, Jun 20, 2012 at 10:35:21AM +0200, Linus Walleij wrote:
> On Tue, Jun 19, 2012 at 2:00 PM, Beno?t Th?baudeau
> <benoit.thebaudeau@advansee.com> wrote:
> 
> > Can you give me an example
> > that tells me by what you replaced those cpu_is_xxx()? By some feature test
> > macros?
> 
> Since this is a DT-enabled driver, add a boolean attribute for
> the DT node like "has-edge-select" and add that attribute to
> the SoC .dtsi files for the SoCs that has this feature.
> 
> Another (better) option is if there are magic numbers in the
> silicon register range that you can check for revision of that
> hardware in itself. Such auto-detect plug-n-play is always best.

If there would be such a register it would almost certainly be on different
register offsets on different SoCs...

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-06-20  9:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18 19:57 [PATCH] gpio/mxc: use the edge_sel feature if available Benoît Thébaudeau
2012-06-19  1:24 ` Shawn Guo
2012-06-19 12:00   ` Benoît Thébaudeau
2012-06-19 13:18     ` Benoît Thébaudeau
2012-06-20  8:35     ` Linus Walleij
2012-06-20  9:21       ` Sascha Hauer [this message]
2012-06-20  9:19 ` Sascha Hauer
2012-06-20 18:27   ` Benoît Thébaudeau
2012-06-20 18:36     ` Benoît Thébaudeau
2012-06-21  6:43     ` Sascha Hauer
2012-06-21 11:23       ` Benoît Thébaudeau
2012-06-22 13:46     ` Guennadi Liakhovetski
2012-06-22 19:04       ` Benoît Thébaudeau
2012-06-27  6:59         ` Sascha Hauer
2012-07-05 13:51           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120620092157.GR28394@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).