From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH V3 2/2] arm/dts: OMAP2: Fix interrupt controller binding
Date: Wed, 20 Jun 2012 06:10:22 -0700 [thread overview]
Message-ID: <20120620131022.GH12766@atomide.com> (raw)
In-Reply-To: <1339548046-27988-3-git-send-email-jon-hunter@ti.com>
* Jon Hunter <jon-hunter@ti.com> [120612 17:45]:
> When booting with device-tree on an OMAP2420H4, the kernel is hanging when
> initialising the interrupts and following kernel dumps is seen ...
>
> [ 0.000000] ------------[ cut here ]------------
> [ 0.000000] WARNING: at arch/arm/mach-omap2/irq.c:271 omap_intc_of_init+0x50/0xb4()
> [ 0.000000] unable to get intc registers
> [ 0.000000] Modules linked in:
> [ 0.000000] [<c001befc>] (unwind_backtrace+0x0/0xf4) from [<c0040c34>] (warn_slowpath_common+0x4c/0x64)
> [ 0.000000] [<c0040c34>] (warn_slowpath_common+0x4c/0x64) from [<c0040ce0>] (warn_slowpath_fmt+0x30/0x40)
> [ 0.000000] [<c0040ce0>] (warn_slowpath_fmt+0x30/0x40) from [<c066b8a4>] (omap_intc_of_init+0x50/0xb4)
> [ 0.000000] [<c066b8a4>] (omap_intc_of_init+0x50/0xb4) from [<c0688b70>] (of_irq_init+0x144/0x288)
> [ 0.000000] [<c0688b70>] (of_irq_init+0x144/0x288) from [<c0663294>] (init_IRQ+0x14/0x1c)
> [ 0.000000] [<c0663294>] (init_IRQ+0x14/0x1c) from [<c06607fc>] (start_kernel+0x198/0x304)
> [ 0.000000] [<c06607fc>] (start_kernel+0x198/0x304) from [<80008044>] (0x80008044)
> [ 0.000000] ---[ end trace 1b75b31a2719ed1c ]---
> [ 0.000000] of_irq_init: children remain, but no parents
>
> The OMAP2 interrupt controller binding is missing the number of interrupts and
> interrupt controller register address. Adding these fixes the problem.
Thanks this is a good one, applying into fixes.
Tony
>
> This is based upon latest linux-omap master (3.5-rc1) git tree.
>
> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
> ---
> arch/arm/boot/dts/omap2.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap2.dtsi b/arch/arm/boot/dts/omap2.dtsi
> index f2ab4ea..581cb08 100644
> --- a/arch/arm/boot/dts/omap2.dtsi
> +++ b/arch/arm/boot/dts/omap2.dtsi
> @@ -44,6 +44,8 @@
> compatible = "ti,omap2-intc";
> interrupt-controller;
> #interrupt-cells = <1>;
> + ti,intc-size = <96>;
> + reg = <0x480FE000 0x1000>;
> };
>
> uart1: serial at 4806a000 {
> --
> 1.7.9.5
>
prev parent reply other threads:[~2012-06-20 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 0:40 [RESEND PATCH V3 0/2] arm/dts: Add OMAP2420 H4 support Jon Hunter
2012-06-13 0:40 ` [RESEND PATCH V3 1/2] arm/dts: OMAP2: Add support for OMAP2420H4 Board Jon Hunter
2012-07-02 8:10 ` Tony Lindgren
2012-06-13 0:40 ` [RESEND PATCH V3 2/2] arm/dts: OMAP2: Fix interrupt controller binding Jon Hunter
2012-06-20 13:10 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620131022.GH12766@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).