From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] ARM: imx: Add basic imx6q cpu thermal management
Date: Wed, 20 Jun 2012 16:20:44 +0200 [thread overview]
Message-ID: <20120620142044.GU28394@pengutronix.de> (raw)
In-Reply-To: <CAMXH7KE0Ei5cZLCOuO-hxBXW8WX48VhxNs2FxPV8biDNqzRY5A@mail.gmail.com>
On Wed, Jun 20, 2012 at 09:12:51AM -0500, Rob Lee wrote:
> Sascha, thanks for the review.
>
> >> +
> >> +static struct imx6q_thermal_zone ? ? *th_zone;
> >> +static void __iomem ? ? ? ? ? ? ? ? ?*ocotp_base;
> >
> > This is a driver and drivers should generally be multi instance safe.
> >
>
> I don't understand what this comment is referring to. Could you elaborate?
Drivers can only be multi instance safe when all variables are inside a
instance specific struct and you pass a pointer to this struct around.
What if the i.MX7 has two different ocotp_base and you want to use this
driver on both ocotp?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-06-20 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 7:06 [PATCH v5] ARM: imx: Add basic imx6q cpu thermal management Robert Lee
2012-06-20 7:06 ` Robert Lee
2012-06-20 8:25 ` Rob Lee
2012-06-20 10:11 ` Sascha Hauer
2012-06-20 14:12 ` Rob Lee
2012-06-20 14:20 ` Sascha Hauer [this message]
2012-06-20 14:33 ` Rob Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120620142044.GU28394@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).