From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [V2 1/3] regulator: add pre-regulator support for 88pm860x
Date: Thu, 21 Jun 2012 11:15:36 +0100 [thread overview]
Message-ID: <20120621101536.GR4037@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1340259538-24239-1-git-send-email-jtzhou@marvell.com>
On Thu, Jun 21, 2012 at 02:18:58PM +0800, Jett.Zhou wrote:
> +static struct regulator_consumer_supply preg_supply[] = {
> + REGULATOR_SUPPLY("preg", NULL),
> +};
This looks wrong, why is there no dev_name being specified?
> +static struct regulator_init_data preg_init_data = {
> + .num_consumer_supplies = 1,
> + .consumer_supplies = &preg_supply[0],
> +};
Use ARRAY_SIZE() since it's an array.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120621/bea6d848/attachment.sig>
next prev parent reply other threads:[~2012-06-21 10:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 6:18 [V2 1/3] regulator: add pre-regulator support for 88pm860x Jett.Zhou
2012-06-21 10:15 ` Mark Brown [this message]
2012-06-21 11:31 ` [V3 " Jett.Zhou
2012-06-21 22:54 ` Mark Brown
2012-07-05 14:24 ` Samuel Ortiz
2012-07-05 14:15 ` Mark Brown
2012-07-06 1:59 ` jett zhou
2012-07-06 2:58 ` [V3 1/4] regulator: 88pm860x: add pre-regulator support for 88pm860x regulator Jett.Zhou
2012-09-13 7:47 ` Haojian Zhuang
2012-07-06 2:59 ` [V3 2/4] mfd: 88pm860x: add pre-regulator device for 88pm860x Jett.Zhou
2012-07-06 9:01 ` Samuel Ortiz
2012-07-06 3:02 ` [V3 3/4] power_supply: Enable battery-charger " Jett.Zhou
2012-07-14 8:12 ` Anton Vorontsov
2012-07-16 5:27 ` jett zhou
2012-07-27 8:28 ` [V4 " Jett.Zhou
2012-08-23 3:48 ` Anton Vorontsov
2012-08-23 4:43 ` Anton Vorontsov
2012-08-23 9:06 ` jett zhou
2012-08-23 12:22 ` Anton Vorontsov
2012-08-23 12:26 ` jett zhou
2012-09-13 7:48 ` Haojian Zhuang
2012-09-20 22:35 ` Anton Vorontsov
2012-09-21 1:01 ` Haojian Zhuang
2012-09-21 22:14 ` Samuel Ortiz
2012-09-21 22:39 ` Anton Vorontsov
2012-07-06 3:02 ` [V3 4/4] ARM: MMP: add 88pm860x battery-charger support Jett.Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621101536.GR4037@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).