From: lethal@linux-sh.org (Paul Mundt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/02] clk: clk-of: Use alloc_bootmem() instead of kzalloc()
Date: Thu, 21 Jun 2012 21:18:44 +0900 [thread overview]
Message-ID: <20120621121843.GA20236@linux-sh.org> (raw)
In-Reply-To: <87395p15or.fsf_-_@octavius.laptop.org>
On Thu, Jun 21, 2012 at 03:32:04AM -0400, Chris Ball wrote:
> When of_clk_add_provider() is used at boot time (during .init_early on
> ARM, in the motivating case for this patch), kzalloc() cannot be used
> because slab isn't up yet.
>
> Signed-off-by: Chris Ball <cjb@laptop.org>
I wouldn't use alloc_bootmem() unconditionally for this, as you have no
idea where other platforms may wire the call site up. slab is also
available a lot earlier now than it used to be, so many places that
required bootmem pages previously can get away with slab allocations now.
You could rework this as:
if (slab_is_available())
cp = kzalloc(...)
else
cp = alloc_bootmem(...)
and then it doesn't matter when and where it gets called.
next prev parent reply other threads:[~2012-06-21 12:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 14:41 [PATCH v3 0/4] DT clock bindings Rob Herring
2012-06-12 14:41 ` [PATCH v3 1/4] clk: add DT clock binding support Rob Herring
2012-06-15 3:17 ` Shawn Guo
2012-06-15 4:32 ` Rob Herring
2012-07-01 22:13 ` [PATCH v6] " Rob Herring
2012-06-12 14:41 ` [PATCH v3 2/4] clk: add DT fixed-clock " Rob Herring
2012-06-12 14:41 ` [PATCH v3 3/4] dt: add clock binding doc to primecell bindings Rob Herring
2012-06-22 13:55 ` Ben Dooks
2012-06-22 14:23 ` Russell King - ARM Linux
2012-06-12 14:41 ` [PATCH v3 4/4] clk: add highbank clock support Rob Herring
2012-06-12 15:47 ` [PATCH v3 0/4] DT clock bindings Mike Turquette
2012-06-12 16:23 ` Rob Herring
2012-06-14 8:49 ` Shawn Guo
2012-06-13 15:26 ` Peter De Schrijver
2012-06-13 18:09 ` Rob Herring
2012-06-15 8:39 ` Shawn Guo
2012-06-15 15:40 ` Stephen Warren
2012-06-15 21:07 ` Rob Herring
2012-06-21 7:27 ` Chris Ball
2012-06-21 7:30 ` [PATCH 01/02] clk: Refactor of_clk_* into a new clk-of.c Chris Ball
2012-06-21 7:32 ` [PATCH 02/02] clk: clk-of: Use alloc_bootmem() instead of kzalloc() Chris Ball
2012-06-21 12:18 ` Paul Mundt [this message]
2012-06-21 15:00 ` [PATCH v3 0/4] DT clock bindings Rob Herring
2012-06-21 17:54 ` Mike Turquette
2012-06-27 12:54 ` Rob Herring
2012-07-03 1:30 ` Turquette, Mike
2012-07-03 2:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621121843.GA20236@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).