From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2 V3] MXS: Set I2C timing registers for mxs-i2c
Date: Sat, 23 Jun 2012 20:19:34 +0200 [thread overview]
Message-ID: <201206232019.34829.marex@denx.de> (raw)
In-Reply-To: <20120611144237.GI2552@S2101-09.ap.freescale.net>
Dear Shawn Guo,
> On Mon, Jun 11, 2012 at 12:53:17PM +0200, Marek Vasut wrote:
> > Ok, then can you please try asking them how to exactly compute the values
> > in timing0-timing2 registers? So we don't have to hardcode them like
> > it's done now?
>
> It's determined I2C clock waveform you want to get. See i.MX28 RM
> "Figure 27-2. I2C Data and Clock Timing" and "Figure 27-3. I2C Data
> and Clock Timing Generation".
>
> For example, if you run 12MHz APBX clock, and set HIGH_COUNT to 60,
> the I2C clock will have 60 cycle x (1/12MHz) = 5us time for its high
> period.
Ok, I think I see the equation. But what still doesn't make sense is how you got
to the value of 48 (RCV_COUNT at 95kHz). And how you got 120 for HIGH_COUNT and
128 for LOW_COUNT?
Were these values based on some measurements, making them the best possible
values? Won't computation of slightly different values affect reliability of
this driver?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-06-23 18:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 11:45 [PATCH 1/2 V3] MXS: Set I2C timing registers for mxs-i2c Marek Vasut
2012-06-09 11:45 ` [PATCH 2/2 V2] MXS: Implement DMA support into mxs-i2c Marek Vasut
2012-06-10 11:53 ` [PATCH 1/2 V3] MXS: Set I2C timing registers for mxs-i2c Marek Vasut
2012-06-11 7:30 ` Shawn Guo
2012-06-11 10:53 ` Marek Vasut
2012-06-11 14:42 ` Shawn Guo
2012-06-23 18:19 ` Marek Vasut [this message]
2012-06-11 6:39 ` Shawn Guo
2012-06-11 10:54 ` Marek Vasut
2012-06-27 1:30 ` Marek Vasut
2012-06-27 2:13 ` Shawn Guo
2012-06-27 2:34 ` Marek Vasut
2012-06-23 18:47 ` Marek Vasut
2012-06-25 15:43 ` Shawn Guo
2012-06-25 16:02 ` Marek Vasut
2012-06-27 1:15 ` Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2012-07-09 16:22 Marek Vasut
2012-07-13 8:07 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206232019.34829.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).