* [PATCH] ARM: mx28: Add LCD pinmux
@ 2012-06-23 18:45 Marek Vasut
2012-06-24 6:28 ` Fabio Estevam
2012-06-26 2:52 ` Shawn Guo
0 siblings, 2 replies; 7+ messages in thread
From: Marek Vasut @ 2012-06-23 18:45 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
CC: Dong Aisheng <b29396@freescale.com>
CC: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Linux ARM kernel <linux-arm-kernel@lists.infradead.org>
CC: Shawn Guo <shawn.guo@linaro.org>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
---
arch/arm/boot/dts/imx28.dtsi | 45 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 464303c..ab29cbe 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -221,6 +221,51 @@
fsl,pull-up = <0>;
};
+ lcd_data_pins_8bpp_a: lcd at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <0x1000 0x1010 0x1020 0x1030
+ 0x1040 0x1050 0x1060 0x1070>;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
+ lcd_data_pins_16bpp_a: lcd at 1 {
+ reg = <0>;
+ fsl,pinmux-ids = <0x1000 0x1010 0x1020 0x1030
+ 0x1040 0x1050 0x1060 0x1070
+ 0x1080 0x1090 0x10a0 0x10b0
+ 0x10c0 0x10d0 0x10e0 0x10f0>;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
+ lcd_data_pins_18bpp_a: lcd at 2 {
+ reg = <0>;
+ fsl,pinmux-ids = <0x1000 0x1010 0x1020 0x1030
+ 0x1040 0x1050 0x1060 0x1070
+ 0x1080 0x1090 0x10a0 0x10b0
+ 0x10c0 0x10d0 0x10e0 0x10f0
+ 0x1100 0x1110>;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
+ lcd_data_pins_24bpp_a: lcd at 3 {
+ reg = <0>;
+ fsl,pinmux-ids = <0x1000 0x1010 0x1020 0x1030
+ 0x1040 0x1050 0x1060 0x1070
+ 0x1080 0x1090 0x10a0 0x10b0
+ 0x10c0 0x10d0 0x10e0 0x10f0
+ 0x1100 0x1110 0x1120 0x1130
+ 0x1140 0x1150 0x1160 0x1170>;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
mac0_pins_a: mac0 at 0 {
reg = <0>;
fsl,pinmux-ids = <0x4000 0x4010 0x4020
--
1.7.10
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] ARM: mx28: Add LCD pinmux
2012-06-23 18:45 [PATCH] ARM: mx28: Add LCD pinmux Marek Vasut
@ 2012-06-24 6:28 ` Fabio Estevam
2012-06-24 13:05 ` Marek Vasut
2012-06-26 2:52 ` Shawn Guo
1 sibling, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2012-06-24 6:28 UTC (permalink / raw)
To: linux-arm-kernel
Hi Marek,
On Sat, Jun 23, 2012 at 3:45 PM, Marek Vasut <marex@denx.de> wrote:
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Detlev Zundel <dzu@denx.de>
> CC: Dong Aisheng <b29396@freescale.com>
> CC: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Linux ARM kernel <linux-arm-kernel@lists.infradead.org>
> CC: Shawn Guo <shawn.guo@linaro.org>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> ---
> ?arch/arm/boot/dts/imx28.dtsi | ? 45 ++++++++++++++++++++++++++++++++++++++++++
> ?1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 464303c..ab29cbe 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -221,6 +221,51 @@
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?fsl,pull-up = <0>;
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?};
>
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? lcd_data_pins_8bpp_a: lcd at 0 {
Please remove the "bpp" from all the names.
bpp is usually used for the pixel depth in a framebuffer, and what you
are describing here is how many bits are physically connected into the
LCD interface.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM: mx28: Add LCD pinmux
2012-06-24 6:28 ` Fabio Estevam
@ 2012-06-24 13:05 ` Marek Vasut
2012-06-24 13:15 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2012-06-24 13:05 UTC (permalink / raw)
To: linux-arm-kernel
Dear Fabio Estevam,
> Hi Marek,
>
> On Sat, Jun 23, 2012 at 3:45 PM, Marek Vasut <marex@denx.de> wrote:
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Detlev Zundel <dzu@denx.de>
> > CC: Dong Aisheng <b29396@freescale.com>
> > CC: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Linux ARM kernel <linux-arm-kernel@lists.infradead.org>
> > CC: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Stefano Babic <sbabic@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> > arch/arm/boot/dts/imx28.dtsi | 45
> > ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45
> > insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 464303c..ab29cbe 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -221,6 +221,51 @@
> > fsl,pull-up = <0>;
> > };
> >
> > + lcd_data_pins_8bpp_a: lcd at 0 {
>
> Please remove the "bpp" from all the names.
>
> bpp is usually used for the pixel depth in a framebuffer, and what you
> are describing here is how many bits are physically connected into the
> LCD interface.
But the BPP should corelate with the number of connected data pins. Or do you
have any counter-argument? And besides, it's much easier to understand like
that.
> Regards,
>
> Fabio Estevam
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM: mx28: Add LCD pinmux
2012-06-24 13:05 ` Marek Vasut
@ 2012-06-24 13:15 ` Fabio Estevam
2012-06-24 13:43 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2012-06-24 13:15 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jun 24, 2012 at 10:05 AM, Marek Vasut <marex@denx.de> wrote:
> But the BPP should corelate with the number of connected data pins. Or do you
> have any counter-argument? And besides, it's much easier to understand like
> that.
This is not true. The pixel depth (bpp) tells how the bits are paked
in the memory and does not correlate with the number of physically
connected pins. For example: you can have a 16 pin LCD and decide to
display it as 16bpp or 32bpp.
So keeping the bpp in the name of these data structure is not correct
as you are only describing the physical connection.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: mx28: Add LCD pinmux
2012-06-24 13:15 ` Fabio Estevam
@ 2012-06-24 13:43 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2012-06-24 13:43 UTC (permalink / raw)
To: linux-arm-kernel
Dear Fabio Estevam,
> On Sun, Jun 24, 2012 at 10:05 AM, Marek Vasut <marex@denx.de> wrote:
> > But the BPP should corelate with the number of connected data pins. Or do
> > you have any counter-argument? And besides, it's much easier to
> > understand like that.
>
> This is not true. The pixel depth (bpp) tells how the bits are paked
> in the memory and does not correlate with the number of physically
> connected pins. For example: you can have a 16 pin LCD and decide to
> display it as 16bpp or 32bpp.
>
> So keeping the bpp in the name of these data structure is not correct
> as you are only describing the physical connection.
Ah that's right ... makes sense now. Will respin the patch.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: mx28: Add LCD pinmux
2012-06-23 18:45 [PATCH] ARM: mx28: Add LCD pinmux Marek Vasut
2012-06-24 6:28 ` Fabio Estevam
@ 2012-06-26 2:52 ` Shawn Guo
2012-06-26 12:17 ` Marek Vasut
1 sibling, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2012-06-26 2:52 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Jun 23, 2012 at 08:45:18PM +0200, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Detlev Zundel <dzu@denx.de>
> CC: Dong Aisheng <b29396@freescale.com>
> CC: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Linux ARM kernel <linux-arm-kernel@lists.infradead.org>
> CC: Shawn Guo <shawn.guo@linaro.org>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> ---
> arch/arm/boot/dts/imx28.dtsi | 45 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 464303c..ab29cbe 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -221,6 +221,51 @@
> fsl,pull-up = <0>;
> };
>
> + lcd_data_pins_8bpp_a: lcd at 0 {
> + reg = <0>;
> + fsl,pinmux-ids = <0x1000 0x1010 0x1020 0x1030
> + 0x1040 0x1050 0x1060 0x1070>;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
> + };
> +
> + lcd_data_pins_16bpp_a: lcd at 1 {
> + reg = <0>;
> + fsl,pinmux-ids = <0x1000 0x1010 0x1020 0x1030
> + 0x1040 0x1050 0x1060 0x1070
> + 0x1080 0x1090 0x10a0 0x10b0
> + 0x10c0 0x10d0 0x10e0 0x10f0>;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
> + };
> +
> + lcd_data_pins_18bpp_a: lcd at 2 {
> + reg = <0>;
> + fsl,pinmux-ids = <0x1000 0x1010 0x1020 0x1030
> + 0x1040 0x1050 0x1060 0x1070
> + 0x1080 0x1090 0x10a0 0x10b0
> + 0x10c0 0x10d0 0x10e0 0x10f0
> + 0x1100 0x1110>;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
> + };
> +
> + lcd_data_pins_24bpp_a: lcd at 3 {
> + reg = <0>;
> + fsl,pinmux-ids = <0x1000 0x1010 0x1020 0x1030
> + 0x1040 0x1050 0x1060 0x1070
> + 0x1080 0x1090 0x10a0 0x10b0
> + 0x10c0 0x10d0 0x10e0 0x10f0
> + 0x1100 0x1110 0x1120 0x1130
> + 0x1140 0x1150 0x1160 0x1170>;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
> + };
> +
We do not want to enumerate all the possible mux options. Instead,
please add mux setting when there is indeed a user for it.
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM: mx28: Add LCD pinmux
2012-06-26 2:52 ` Shawn Guo
@ 2012-06-26 12:17 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2012-06-26 12:17 UTC (permalink / raw)
To: linux-arm-kernel
Dear Shawn Guo,
> On Sat, Jun 23, 2012 at 08:45:18PM +0200, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Detlev Zundel <dzu@denx.de>
> > CC: Dong Aisheng <b29396@freescale.com>
> > CC: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Linux ARM kernel <linux-arm-kernel@lists.infradead.org>
> > CC: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Stefano Babic <sbabic@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> >
> > arch/arm/boot/dts/imx28.dtsi | 45
> > ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45
> > insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 464303c..ab29cbe 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -221,6 +221,51 @@
> >
> > fsl,pull-up = <0>;
> >
> > };
> >
> > + lcd_data_pins_8bpp_a: lcd at 0 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <0x1000 0x1010 0x1020
0x1030
> > + 0x1040 0x1050 0x1060 0x1070>;
> > + fsl,drive-strength = <0>;
> > + fsl,voltage = <1>;
> > + fsl,pull-up = <0>;
> > + };
> > +
> > + lcd_data_pins_16bpp_a: lcd at 1 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <0x1000 0x1010 0x1020
0x1030
> > + 0x1040 0x1050 0x1060 0x1070
> > + 0x1080 0x1090 0x10a0 0x10b0
> > + 0x10c0 0x10d0 0x10e0 0x10f0>;
> > + fsl,drive-strength = <0>;
> > + fsl,voltage = <1>;
> > + fsl,pull-up = <0>;
> > + };
> > +
> > + lcd_data_pins_18bpp_a: lcd at 2 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <0x1000 0x1010 0x1020
0x1030
> > + 0x1040 0x1050 0x1060 0x1070
> > + 0x1080 0x1090 0x10a0 0x10b0
> > + 0x10c0 0x10d0 0x10e0 0x10f0
> > + 0x1100 0x1110>;
> > + fsl,drive-strength = <0>;
> > + fsl,voltage = <1>;
> > + fsl,pull-up = <0>;
> > + };
> > +
> > + lcd_data_pins_24bpp_a: lcd at 3 {
> > + reg = <0>;
> > + fsl,pinmux-ids = <0x1000 0x1010 0x1020
0x1030
> > + 0x1040 0x1050 0x1060 0x1070
> > + 0x1080 0x1090 0x10a0 0x10b0
> > + 0x10c0 0x10d0 0x10e0 0x10f0
> > + 0x1100 0x1110 0x1120 0x1130
> > + 0x1140 0x1150 0x1160 0x1170>;
> > + fsl,drive-strength = <0>;
> > + fsl,voltage = <1>;
> > + fsl,pull-up = <0>;
> > + };
> > +
>
> We do not want to enumerate all the possible mux options. Instead,
> please add mux setting when there is indeed a user for it.
Well, I'd prefer to have it ready to be used, instead of having partial slabs of
muxes. But whatever.
Is anyone converting the LCD driver over to DT or not?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-06-26 12:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-23 18:45 [PATCH] ARM: mx28: Add LCD pinmux Marek Vasut
2012-06-24 6:28 ` Fabio Estevam
2012-06-24 13:05 ` Marek Vasut
2012-06-24 13:15 ` Fabio Estevam
2012-06-24 13:43 ` Marek Vasut
2012-06-26 2:52 ` Shawn Guo
2012-06-26 12:17 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).